From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Venkatraman S <svenkatr@ti.com>,
Senthilvadivu Guruswamy <svadivu@ti.com>,
Angelo Arrifano <miknix@gmail.com>,
"Zebediah C. McClure" <zmc@lurian.net>,
Alistair Buxton <a.j.buxton@gmail.com>,
Paul Walmsley <paul@pwsan.com>, Sanjeev Premi <premi@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Tomi Valkeinen <tomi.valkeinen@nokia.com>,
Aaro Koskinen <aaro.koskinen@nokia.com>,
Vikram Pandita <vikram.pandita@ti.com>,
Vishwanath S <vishwa.s@ti.com>
Subject: Re: [PATCH 6/9] omap: move generic omap3 features to generic
Date: Wed, 7 Jul 2010 15:30:03 +0300 [thread overview]
Message-ID: <20100707123002.GS1920@atomide.com> (raw)
In-Reply-To: <1277259375-18521-7-git-send-email-nm@ti.com>
* Nishanth Menon <nm@ti.com> [100623 05:15]:
> @@ -354,11 +354,11 @@ static void __init omap3_cpuinfo(void)
> /* Print verbose information */
> pr_info("%s ES%s (", cpu_name, cpu_rev);
>
> - OMAP_SHOW_FEATURE(3, l2cache);
> - OMAP_SHOW_FEATURE(3, iva);
> - OMAP_SHOW_FEATURE(3, sgx);
> - OMAP_SHOW_FEATURE(3, neon);
> - OMAP_SHOW_FEATURE(3, isp);
> + OMAP_SHOW_FEATURE(, l2cache);
> + OMAP_SHOW_FEATURE(, iva);
> + OMAP_SHOW_FEATURE(, sgx);
> + OMAP_SHOW_FEATURE(, neon);
> + OMAP_SHOW_FEATURE(, isp);
> OMAP_SHOW_FEATURE(3, 192mhz_clk);
Then you can simplify OMAP_SHOW_FEATURE too as
the "3, " should not be needed?
Tony
next prev parent reply other threads:[~2010-07-07 12:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 2:16 [PATCH 0/9 v2] introduce generic OMAP SOC features Nishanth Menon
2010-06-23 2:16 ` [PATCH 1/9] omap1: rename check_revision Nishanth Menon
2010-06-23 2:16 ` [PATCH 2/9] omap2/3: id: fix sparse warning Nishanth Menon
2010-06-23 2:16 ` [PATCH 3/9] omap: generic: introduce a single check_revision Nishanth Menon
2010-06-25 9:31 ` Grazvydas Ignotas
2010-06-25 13:18 ` Nishanth Menon
2010-06-23 2:16 ` [PATCH 4/9] omap: improve OMAP3_HAS_FEATURE Nishanth Menon
2010-07-07 12:28 ` Tony Lindgren
2010-07-07 13:15 ` Nishanth Menon
2010-07-07 13:30 ` Tony Lindgren
2010-07-07 13:50 ` Nishanth Menon
2010-07-08 9:24 ` Tony Lindgren
2010-06-23 2:16 ` [PATCH 5/9] omap: introduce OMAP_SHOW_FEATURE Nishanth Menon
2010-06-23 2:16 ` [PATCH 6/9] omap: move generic omap3 features to generic Nishanth Menon
2010-07-07 12:30 ` Tony Lindgren [this message]
2010-06-23 2:16 ` [PATCH 7/9] omap: introduce omap4 feature Nishanth Menon
2010-06-23 2:16 ` [PATCH 8/9] omap: introduce omap24xx generic features Nishanth Menon
2010-06-23 2:16 ` [PATCH 9/9] omap: id: add feature check for omap1 Nishanth Menon
2010-07-06 12:46 ` Tony Lindgren
2010-07-06 12:53 ` Nishanth Menon
2010-07-06 13:14 ` Tony Lindgren
2010-07-06 16:07 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707123002.GS1920@atomide.com \
--to=tony@atomide.com \
--cc=a.j.buxton@gmail.com \
--cc=aaro.koskinen@nokia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=miknix@gmail.com \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=premi@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=svadivu@ti.com \
--cc=svenkatr@ti.com \
--cc=tomi.valkeinen@nokia.com \
--cc=vikram.pandita@ti.com \
--cc=vishwa.s@ti.com \
--cc=zmc@lurian.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).