From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Nishanth Menon <nm@ti.com>, linux-omap@vger.kernel.org
Subject: [PATCH 3/5] omap2/3/4: serial: kill dev_attr_sleep_timeout sparse warn
Date: Thu, 08 Jul 2010 13:08:22 +0300 [thread overview]
Message-ID: <20100708100822.19285.15230.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100708100715.19285.30066.stgit@baageli.muru.com>
From: Nishanth Menon <nm@ti.com>
Remove the following sparse warnings by declaring attr as static:
arch/arm/mach-omap2/serial.c:627:1: warning: symbol 'dev_attr_sleep_timeout'
was not declared. Should it be static?
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/serial.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index 9476c1c..584a2ed 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -558,7 +558,8 @@ static ssize_t sleep_timeout_store(struct device *dev,
return n;
}
-DEVICE_ATTR(sleep_timeout, 0644, sleep_timeout_show, sleep_timeout_store);
+static DEVICE_ATTR(sleep_timeout, 0644, sleep_timeout_show,
+ sleep_timeout_store);
#define DEV_CREATE_FILE(dev, attr) WARN_ON(device_create_file(dev, attr))
#else
static inline void omap_uart_idle_init(struct omap_uart_state *uart) {}
next prev parent reply other threads:[~2010-07-08 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 10:08 [PATCH 0/5] omap serial init patches for 2.6.36 merge window Tony Lindgren
2010-07-08 10:08 ` [PATCH 1/5] omap3: serial: Add context save and restore for mcr Tony Lindgren
2010-07-08 10:08 ` [PATCH 2/5] omap2/3/4: serial: remove initialization sparse warnings Tony Lindgren
2010-07-08 10:08 ` Tony Lindgren [this message]
2010-07-08 10:08 ` [PATCH 4/5] omap2/3/4: serial: introduce errata handling Tony Lindgren
2010-07-08 10:08 ` [PATCH 5/5] omap2/3/4: serial: errata i202: fix for MDR1 access Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2010-06-23 4:17 [PATCH 0/5 v2] omap2/3/4: serial fixes Nishanth Menon
2010-06-23 4:17 ` [PATCH 3/5] omap2/3/4: serial: kill dev_attr_sleep_timeout sparse warn Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708100822.19285.15230.stgit@baageli.muru.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).