From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Shubhrajyoti D <shubhrajyoti@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] [RFC] Remove the debug print noise
Date: Mon, 2 Aug 2010 15:52:15 +0300 [thread overview]
Message-ID: <20100802125215.GA30753@nokia.com> (raw)
In-Reply-To: <1280753271-21182-1-git-send-email-shubhrajyoti@ti.com>
Hi,
On Mon, Aug 02, 2010 at 02:47:51PM +0200, ext Shubhrajyoti D wrote:
>@@ -626,7 +626,7 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
> if (r < 0)
> return r;
> if (r == 0) {
>- dev_err(dev->dev, "controller timed out\n");
>+ dev_dbg(dev->dev, "controller timed out\n");
you would better be searching for the cause of the timeout. 1 second is
enough time (or should be) for any i2c command to complete. If you have
an easy way to reproduce this problem, then better search for its
rootcause. If I remember correctly, this timeout was put here for a good
reason.
Tony, any comments ?
--
balbi
DefectiveByDesign.org
next prev parent reply other threads:[~2010-08-02 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 12:47 [PATCH] [RFC] Remove the debug print noise Shubhrajyoti D
2010-08-02 12:52 ` Felipe Balbi [this message]
2010-08-02 12:59 ` Datta, Shubhrajyoti
2010-08-02 13:47 ` Nishanth Menon
2010-08-06 9:14 ` Tony Lindgren
2010-08-10 10:39 ` DebBarma, Tarun Kanti
2010-08-10 11:52 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802125215.GA30753@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).