[Regression] ads7846.c touchscreen controller driver reports wrong X,Y values

[Regression] ads7846.c touchscreen controller driver reports wrong X,Y values

[Mickael Chazaux]

Hi,

I am working on adding the support of an omap3 based board in the
kernel. This board uses an ADS7843 touchscreen controller, on the SPI
bus. The in-kernel driver (drivers/input/touchscreen/ads7646.c) works
fine with the 2.6.33 kernel. When updating to the 2.6.34 kernel the
values reported by the driver were garbage. I had to revert this
commit [1] to make it work again. Can someone confirm that this driver
still works with other OMAP boards?

[1] a330ce2001b290c59fe98c37e981683ef0a75fdf

Regards,

Mickael

Adeneo Embedded - Adetel Group
2, chemin du Ruisseau
69134 ECULLY - FRANCE
Tél. : +33 (0)4 72 18 08 40 - Fax : +33 (0)4 72 18 08 41
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Regression] ads7846.c touchscreen controller driver reports wrong X,Y values

[Steve Sakoman]

On Tue, May 25, 2010 at 8:54 AM, Mickael Chazaux
<mickael.chazaux@gmail.com> wrote:
> Hi,
>
> I am working on adding the support of an omap3 based board in the
> kernel. This board uses an ADS7843 touchscreen controller, on the SPI
> bus. The in-kernel driver (drivers/input/touchscreen/ads7646.c) works
> fine with the 2.6.33 kernel. When updating to the 2.6.34 kernel the
> values reported by the driver were garbage. I had to revert this
> commit [1] to make it work again. Can someone confirm that this driver
> still works with other OMAP boards?
>
> [1] a330ce2001b290c59fe98c37e981683ef0a75fdf

I can confirm that the above patch also breaks the ADS7846 driver on
Overo.  Reverting it results in correct operation.

Steve





> Regards,
>
> Mickael
>
> Adeneo Embedded - Adetel Group
> 2, chemin du Ruisseau
> 69134 ECULLY - FRANCE
> Tél. : +33 (0)4 72 18 08 40 - Fax : +33 (0)4 72 18 08 41
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Regression] ads7846.c touchscreen controller driver reports wrong X,Y values

[Tony Lindgren]

* Steve Sakoman <sakoman@gmail.com> [100710 01:10]:
> On Tue, May 25, 2010 at 8:54 AM, Mickael Chazaux
> <mickael.chazaux@gmail.com> wrote:
> > Hi,
> >
> > I am working on adding the support of an omap3 based board in the
> > kernel. This board uses an ADS7843 touchscreen controller, on the SPI
> > bus. The in-kernel driver (drivers/input/touchscreen/ads7646.c) works
> > fine with the 2.6.33 kernel. When updating to the 2.6.34 kernel the
> > values reported by the driver were garbage. I had to revert this
> > commit [1] to make it work again. Can someone confirm that this driver
> > still works with other OMAP boards?
> >
> > [1] a330ce2001b290c59fe98c37e981683ef0a75fdf
> 
> I can confirm that the above patch also breaks the ADS7846 driver on
> Overo.  Reverting it results in correct operation.

Hmm, does reading the OMAP2_MCSPI_CHCONF0 register have some side effect?

Regards,

Tony