From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] omap: device: improve errors handling Date: Wed, 4 Aug 2010 12:46:39 +0300 Message-ID: <20100804094638.GC9881@atomide.com> References: <1278941887.16634.85.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:59563 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754207Ab0HDJqO (ORCPT ); Wed, 4 Aug 2010 05:46:14 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Artem Bityutskiy , linux-omap , "ext Menon, Nishanth" , Thara Gopinath * Paul Walmsley [100712 19:24]: > Tony, > > by the way, > > On Mon, 12 Jul 2010, Paul Walmsley wrote: > > > On Mon, 12 Jul 2010, Artem Bityutskiy wrote: > > > > > From: Artem Bityutskiy > > > > > > Do not forget to check the 'platform_device_add_data()' error code > > > in 'omap_device_build_ss()'. > > > > Looks fine to me, platform_device_add_data() can return -ENOMEM in the > > unlikely event that its kmemdup() fails. > > > > Acked-by: Paul Walmsley > > you want to take this one, or want me to queue it up for .37? Thanks, I'll add it to omap-for-linus for 2.6.36. Regards, Tony