From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>
Cc: Anand Gadiyar <gadiyar@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Nishanth Menon <nm@ti.com>, Manjunatha GK <manjugk@ti.com>
Subject: Re: [PATCH v2] OMAP3630: Add ES1.1 and ES1.2 detection
Date: Wed, 4 Aug 2010 14:01:42 +0300 [thread overview]
Message-ID: <20100804110142.GA19377@nokia.com> (raw)
In-Reply-To: <20100804105138.GJ9881@atomide.com>
hi,
On Wed, Aug 04, 2010 at 12:51:39PM +0200, ext Tony Lindgren wrote:
>diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
>index fd1904b..0a0ff0c 100644
>--- a/arch/arm/mach-omap2/id.c
>+++ b/arch/arm/mach-omap2/id.c
>@@ -269,11 +269,29 @@ static void __init omap3_check_revision(void)
> omap_chip.oc |= CHIP_IS_OMAP3430ES3_1;
> break;
> case 0xb891:
>+ /* Handle 36xx devices */
>+ omap_chip.oc |= CHIP_IS_OMAP3630ES1;
>+
>+ switch(rev) {
>+ case 0: /* Take care of early samples */
>+ omap_revision = OMAP3630_REV_ES1_0;
>+ break;
>+ case 1:
>+ omap_revision = OMAP3630_REV_ES1_1;
>+ omap_chip.oc |= CHIP_IS_OMAP3630ES1_1;
>+ break;
>+ case 2:
>+ omap_revision = OMAP3630_REV_ES1_2;
>+ omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;
>+ break;
>+ default:
>+ /* FALLTHROUGH */
did you forget a break here
>+ }
> /* FALLTHROUGH */
> default:
> /* Unknown default to latest silicon rev as default*/
>- omap_revision = OMAP3630_REV_ES1_0;
>- omap_chip.oc |= CHIP_IS_OMAP3630ES1;
>+ omap_revision = OMAP3630_REV_ES1_2;
>+ omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;
and here ?
--
balbi
DefectiveByDesign.org
next prev parent reply other threads:[~2010-08-04 11:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 10:00 Tony mostly offline for the rest of July Tony Lindgren
2010-07-08 17:37 ` Gadiyar, Anand
2010-07-09 7:29 ` Tony Lindgren
2010-07-09 23:17 ` [PATCH] OMAP3630: Add ES1.1 and ES1.2 detection Anand Gadiyar
2010-08-03 7:39 ` Tony Lindgren
2010-08-03 7:43 ` Gadiyar, Anand
2010-08-03 19:59 ` [PATCH v2] " Anand Gadiyar
2010-08-04 10:30 ` Tony Lindgren
2010-08-04 10:51 ` Tony Lindgren
2010-08-04 10:55 ` Gadiyar, Anand
2010-08-04 11:01 ` Felipe Balbi [this message]
2010-08-04 11:06 ` Tony Lindgren
2010-08-04 11:09 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804110142.GA19377@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).