Board mux entries ignored?

Board mux entries ignored?

[John Faith]

Hi,
I'm trying to set mux modes for a 3530, package CBC in my board.c
(2.6.32 kernel) using an omap_board_mux entry:
 OMAP3_MUX(GPMC_WAIT1, OMAP_MUX_MODE0 | OMAP_PIN_INPUT),

, but sysfs reports mode4:
# grep WAIT1 /sys/kernel/debug/omap_mux/board
OMAP3_MUX(GPMC_WAIT1, OMAP_PIN_INPUT | OMAP_MUX_MODE4),

I tried adding to bootargs "omap_mux=gpmc_wait1.gpmc_wait1=0x100", but
still got MODE4.  Doing "echo 0x100 >
/sys/kernel/debug/omap_mux/gpmc_wait1" gave me MODE0, but I'd prefer
to init pins in board.c.  I've also noticed for pin SDMMC2_DAT3 that
my OMAP3_MUX() entry specifies MODE1, but sysfs shows MODE4; it
changed to MODE1 after adding:
 omap_mux_init_signal("mcspi3_cs0", OMAP_PIN_OUTPUT);

Is just having the mode in omap_board_mux entries sufficient?

Thanks!
,
John

Re: Board mux entries ignored?

[Tony Lindgren]

* John Faith <jfaith7@gmail.com> [100804 22:22]:
> Hi,
> I'm trying to set mux modes for a 3530, package CBC in my board.c
> (2.6.32 kernel) using an omap_board_mux entry:
>  OMAP3_MUX(GPMC_WAIT1, OMAP_MUX_MODE0 | OMAP_PIN_INPUT),
> 
> , but sysfs reports mode4:
> # grep WAIT1 /sys/kernel/debug/omap_mux/board
> OMAP3_MUX(GPMC_WAIT1, OMAP_PIN_INPUT | OMAP_MUX_MODE4),
> 
> I tried adding to bootargs "omap_mux=gpmc_wait1.gpmc_wait1=0x100", but
> still got MODE4.  Doing "echo 0x100 >
> /sys/kernel/debug/omap_mux/gpmc_wait1" gave me MODE0, but I'd prefer
> to init pins in board.c.  I've also noticed for pin SDMMC2_DAT3 that
> my OMAP3_MUX() entry specifies MODE1, but sysfs shows MODE4; it
> changed to MODE1 after adding:
>  omap_mux_init_signal("mcspi3_cs0", OMAP_PIN_OUTPUT);
> 
> Is just having the mode in omap_board_mux entries sufficient?

Hmm that should be enough. Does dmesg | grep -i mux show any errors?

You do have CONFIG_OMAP_MUX set, right? Otherwise omap_mux_init_signals
does not do anything, and the mux code just builds a list of GPIO
pins for PM runtime muxing (not implemented yet).

Regards,

Tony

Re: Board mux entries ignored?

[John Faith]

On Wed, Aug 4, 2010 at 11:54 PM, Tony Lindgren <tony@atomide.com> wrote:
> * John Faith <jfaith7@gmail.com> [100804 22:22]:
>> Hi,
>> I'm trying to set mux modes for a 3530, package CBC in my board.c
>> (2.6.32 kernel) using an omap_board_mux entry:
>>  OMAP3_MUX(GPMC_WAIT1, OMAP_MUX_MODE0 | OMAP_PIN_INPUT),
>>
>> , but sysfs reports mode4:
>> # grep WAIT1 /sys/kernel/debug/omap_mux/board
>> OMAP3_MUX(GPMC_WAIT1, OMAP_PIN_INPUT | OMAP_MUX_MODE4),
>>
>> I tried adding to bootargs "omap_mux=gpmc_wait1.gpmc_wait1=0x100", but
>> still got MODE4.  Doing "echo 0x100 >
>> /sys/kernel/debug/omap_mux/gpmc_wait1" gave me MODE0, but I'd prefer
>> to init pins in board.c.  I've also noticed for pin SDMMC2_DAT3 that
>> my OMAP3_MUX() entry specifies MODE1, but sysfs shows MODE4; it
>> changed to MODE1 after adding:
>>  omap_mux_init_signal("mcspi3_cs0", OMAP_PIN_OUTPUT);
>>
>> Is just having the mode in omap_board_mux entries sufficient?
>
> Hmm that should be enough. Does dmesg | grep -i mux show any errors?
>
> You do have CONFIG_OMAP_MUX set, right? Otherwise omap_mux_init_signals
> does not do anything, and the mux code just builds a list of GPIO
> pins for PM runtime muxing (not implemented yet).

Hi,
Yes, CONFIG_OMAP_MUX is set.  The only non-wait1 error I saw was:
mux: Multiple signal paths (3) for mcspi3_cs0

With CONFIG_OMAP_MUX_DEBUG I now see that after mode0 is set, later
it's set to mode4:
# dmesg | grep -i wait1
mux: Setting signal gpmc_wait1.gpmc_wait1 0x0100 -> 0x0100
mux: Setting signal gpmc_wait1.gpio63 0x0100 -> 0x0104

The same pin was enabled for a different config, fixed with an ifdef.

Thanks!
,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Board mux entries ignored?

[Tony Lindgren]

* John Faith <jfaith7@gmail.com> [100805 19:09]:
> On Wed, Aug 4, 2010 at 11:54 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * John Faith <jfaith7@gmail.com> [100804 22:22]:
> >> Hi,
> >> I'm trying to set mux modes for a 3530, package CBC in my board.c
> >> (2.6.32 kernel) using an omap_board_mux entry:
> >>  OMAP3_MUX(GPMC_WAIT1, OMAP_MUX_MODE0 | OMAP_PIN_INPUT),
> >>
> >> , but sysfs reports mode4:
> >> # grep WAIT1 /sys/kernel/debug/omap_mux/board
> >> OMAP3_MUX(GPMC_WAIT1, OMAP_PIN_INPUT | OMAP_MUX_MODE4),
> >>
> >> I tried adding to bootargs "omap_mux=gpmc_wait1.gpmc_wait1=0x100", but
> >> still got MODE4.  Doing "echo 0x100 >
> >> /sys/kernel/debug/omap_mux/gpmc_wait1" gave me MODE0, but I'd prefer
> >> to init pins in board.c.  I've also noticed for pin SDMMC2_DAT3 that
> >> my OMAP3_MUX() entry specifies MODE1, but sysfs shows MODE4; it
> >> changed to MODE1 after adding:
> >>  omap_mux_init_signal("mcspi3_cs0", OMAP_PIN_OUTPUT);
> >>
> >> Is just having the mode in omap_board_mux entries sufficient?
> >
> > Hmm that should be enough. Does dmesg | grep -i mux show any errors?
> >
> > You do have CONFIG_OMAP_MUX set, right? Otherwise omap_mux_init_signals
> > does not do anything, and the mux code just builds a list of GPIO
> > pins for PM runtime muxing (not implemented yet).
> 
> Hi,
> Yes, CONFIG_OMAP_MUX is set.  The only non-wait1 error I saw was:
> mux: Multiple signal paths (3) for mcspi3_cs0
> 
> With CONFIG_OMAP_MUX_DEBUG I now see that after mode0 is set, later
> it's set to mode4:
> # dmesg | grep -i wait1
> mux: Setting signal gpmc_wait1.gpmc_wait1 0x0100 -> 0x0100
> mux: Setting signal gpmc_wait1.gpio63 0x0100 -> 0x0104
> 
> The same pin was enabled for a different config, fixed with an ifdef.

OK, good to hear.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html