From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONACHED L1 entries
Date: Sun, 8 Aug 2010 12:34:04 +0100 [thread overview]
Message-ID: <20100808113403.GA23623@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1281262672-27626-1-git-send-email-santosh.shilimkar@ti.com>
On Sun, Aug 08, 2010 at 03:47:52PM +0530, Santosh Shilimkar wrote:
> @@ -475,6 +486,9 @@ static void __init build_mem_type_table(void)
> mem_types[MT_LOW_VECTORS].prot_l1 |= ecc_mask;
> mem_types[MT_HIGH_VECTORS].prot_l1 |= ecc_mask;
> mem_types[MT_MEMORY].prot_sect |= ecc_mask | cp->pmd;
> + mem_types[MT_MEMORY].prot_pte |= kern_pgprot;
> + mem_types[MT_MEMORY_NONCACHED].prot_sect |= ecc_mask | cp->pmd;
> + mem_types[MT_MEMORY_NONCACHED].prot_pte |= kern_pgprot;
This is wrong - it will result in the non-cached memory mapped in as
sections having the same cache settings as MT_MEMORY - in other
words, probably write back.
next prev parent reply other threads:[~2010-08-08 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 10:17 [PATCH 1/3] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONACHED L1 entries Santosh Shilimkar
2010-08-08 11:34 ` Russell King - ARM Linux [this message]
2010-08-08 11:46 ` Shilimkar, Santosh
2010-08-09 9:19 ` Shilimkar, Santosh
2010-08-08 11:35 ` Russell King - ARM Linux
2010-08-08 11:44 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100808113403.GA23623@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).