From: Sam Ravnborg <sam@ravnborg.org>
To: Jacob Tanenbaum <Jacob.Tanenbaum@logicpd.com>
Cc: linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk,
tony@atomide.com
Subject: Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM andTORPEDO development kits
Date: Wed, 11 Aug 2010 20:57:55 +0200 [thread overview]
Message-ID: <20100811185755.GA3527@merkur.ravnborg.org> (raw)
In-Reply-To: <77A0A4DB5BF2A44283E5522C27234AC6021C82D5@EDPRSRV011.logicpd.com>
Hi Jacob.
Quick feedback!
You should teach your mailer better manners so it is
visible what you quote and what you answer.
>
> > +static void __init omap3logic_init_irq(void)
> > +{
> > + omap_board_config = omap3logic_config;
> > + omap_board_config_size = ARRAY_SIZE(omap3logic_config);
> > + omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
> > + mt46h32m32lf6_sdrc_params);
> > + omap_init_irq();
> > +#ifdef CONFIG_OMAP_32K_TIMER
> > + omap2_gp_clockevent_set_gptimer(12);
> > +#endif
>
> Fix this on the called site. There is zero reason
> to sprinkle all user of omap2_gp_clockevent_set_gptimer()
> with ifdef/endif.
>
> Will fix
I noticed other users of omap2_gp_clockevent_set_gptimer()
does the same ifdef/endif.
You should take care of them when you have a proper way to do so.
Obviously in another patch.
Sam
next prev parent reply other threads:[~2010-08-11 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 16:31 [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits Jacob Tanenbaum
2010-08-11 16:31 ` [PATCH 2/4] Low-level initialization for hsmmc controller on LogicPD's OMAP3 SOM and TORPEDO dev kits Jacob Tanenbaum
2010-08-11 16:31 ` [PATCH 3/4] add generic smsc911x support for LogicPD's OMAP3 TORPEDO and SOM " Jacob Tanenbaum
2010-08-11 16:31 ` [PATCH 4/4] enabling Ethernet " Jacob Tanenbaum
2010-08-11 17:25 ` [PATCH 2/4] Low-level initialization for hsmmc controller on LogicPD's OMAP3 SOM and TORPEDO " Felipe Balbi
2010-08-11 18:47 ` Jacob Tanenbaum
2010-08-11 18:07 ` Kevin Hilman
2010-08-11 17:22 ` [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits Felipe Balbi
2010-08-11 18:45 ` Jacob Tanenbaum
2010-08-11 18:49 ` Felipe Balbi
2010-08-11 18:51 ` Jacob Tanenbaum
2010-08-11 18:54 ` Felipe Balbi
2010-08-11 17:54 ` Sam Ravnborg
2010-08-11 18:53 ` [PATCH 1/4] initial support for LogicPD's OMAP3 SOM andTORPEDO " Jacob Tanenbaum
2010-08-11 18:57 ` Sam Ravnborg [this message]
2010-08-11 18:04 ` [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO " Kevin Hilman
2010-08-11 18:53 ` Jacob Tanenbaum
2010-08-11 21:13 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100811185755.GA3527@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=Jacob.Tanenbaum@logicpd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rmk@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox