From: Tony Lindgren <tony@atomide.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: omap3630: cpu revision bits are different
Date: Fri, 13 Aug 2010 09:22:57 +0300 [thread overview]
Message-ID: <20100813062255.GA12706@atomide.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB59301E81471BE@dbde02.ent.ti.com>
* Premi, Sanjeev <premi@ti.com> [100812 15:42]:
> Hi all,
>
> While re working on the cpu revision patch, I came
> across these definitions:
>
> #define OMAP3630_REV_ES1_0 0x36300034
> #define OMAP3630_REV_ES1_1 0x36300134
> #define OMAP3630_REV_ES1_2 0x36300234
>
> Contrast this with:
>
> #define OMAP3430_REV_ES1_0 0x34300034
> #define OMAP3430_REV_ES2_0 0x34301034
> #define OMAP3430_REV_ES2_1 0x34302034
>
> I may have missed the discussion on this list, but
> wanted to quickly check if the difference in intended
> OR accidental.
Hmm for those defines it should be just a running
number for the revision so we should most likely
just renumber the OMAP3430_REV_ES bits.
> I do recognize that definitions for 3630 start at lower
> nibble, so they appear to be better choice.
Yeah. Care to do a patch to renumber 3430 revision
bits for the next merge window? AFAIK, that should
change anything in the functionality so it's only
a cosmetic change. Should be grepped carefully though :)
Tony
next prev parent reply other threads:[~2010-08-13 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 12:48 omap3630: cpu revision bits are different Premi, Sanjeev
2010-08-13 6:22 ` Tony Lindgren [this message]
2010-08-13 7:54 ` Premi, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100813062255.GA12706@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox