From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Keshava Munegowda <keshava_mgowda@ti.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support
Date: Fri, 20 Aug 2010 08:38:44 +0300 [thread overview]
Message-ID: <20100820053844.GB15196@nokia.com> (raw)
In-Reply-To: <1282175377-2784-4-git-send-email-keshava_mgowda@ti.com>
Hi,
On Thu, Aug 19, 2010 at 01:49:33AM +0200, ext Keshava Munegowda wrote:
>@@ -298,7 +327,163 @@ static int omap_start_ehc(struct ehci_hc
> }
>
> if (cpu_is_omap44xx()) {
>- /* TODO */
driver should never make use of cpu_is_omap* calls neither machine_is_*
for that matter. Driver shouldn't care about correct clock names either.
You need to find a better to handle differences between omap3 and omap4.
--
balbi
DefectiveByDesign.org
next prev parent reply other threads:[~2010-08-20 5:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 23:49 [PATCH 0/7] usb: ehci: omap: Adding OMAP4 support Keshava Munegowda
2010-08-18 23:49 ` [RFC] [PATCH 1/7] usb: ehci-omap: Add the HSUSB base address Keshava Munegowda
[not found] ` <1282175377-2784-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49 ` [RFC] [PATCH 2/7] usb: ehci-omap: don't execute OMAP3-specific code on non-OMAP3 Keshava Munegowda
[not found] ` <1282175377-2784-3-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49 ` [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support Keshava Munegowda
[not found] ` <1282175377-2784-4-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49 ` [RFC] [PATCH 4/7] omap: usb: ehci: IO mux mode settings for omap4 Keshava Munegowda
[not found] ` <1282175377-2784-5-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49 ` [RFC] [PATCH 5/7] omap: usb: ehci: Initialize resources " Keshava Munegowda
2010-08-18 23:49 ` [RFC] [PATCH 6/7] usb: ehci: Introduce CONFIG_USB_EHCI_HCD_OMAP3 Keshava Munegowda
2010-08-20 5:41 ` Felipe Balbi
[not found] ` <1282175377-2784-7-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-18 23:49 ` [RFC] [PATCH 7/7] omap: ehci: enable the ehci port on OMAP4SDP Keshava Munegowda
2010-08-20 5:45 ` [RFC] [PATCH 6/7] usb: ehci: Introduce CONFIG_USB_EHCI_HCD_OMAP3 Felipe Balbi
[not found] ` <20100820054507.GE15196-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-08-20 5:59 ` Gadiyar, Anand
[not found] ` <5A47E75E594F054BAF48C5E4FC4B92AB0324222B65-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-08-20 6:13 ` Felipe Balbi
2010-08-20 6:32 ` Gadiyar, Anand
2010-08-20 9:13 ` Felipe Balbi
[not found] ` <20100820091336.GC31377-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-20 17:30 ` Menon, Nishanth
[not found] ` <1282175377-2784-6-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-08-20 5:39 ` [RFC] [PATCH 5/7] omap: usb: ehci: Initialize resources for omap4 Felipe Balbi
2010-08-20 5:38 ` Felipe Balbi [this message]
[not found] ` <20100820053844.GB15196-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-08-20 5:47 ` [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support Gadiyar, Anand
2010-08-20 5:52 ` Felipe Balbi
2010-08-20 6:03 ` Gadiyar, Anand
[not found] ` <20100820055204.GF15196-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-08-20 6:24 ` Gadiyar, Anand
[not found] ` <5A47E75E594F054BAF48C5E4FC4B92AB0324222B50-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-08-20 6:01 ` Shilimkar, Santosh
2010-08-20 5:35 ` [RFC] [PATCH 2/7] usb: ehci-omap: don't execute OMAP3-specific code on non-OMAP3 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820053844.GB15196@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).