From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: Nishanth Menon <nm@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Tony Lindgren <tony@atomide.com>,
"ext G, Manjunath Kondaiah" <manjugk@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] OMAP: McBSP: Fix static function warning
Date: Wed, 8 Sep 2010 10:28:36 +0300 [thread overview]
Message-ID: <20100908102836.04e64383.jhnikula@gmail.com> (raw)
In-Reply-To: <201009080903.09652.peter.ujfalusi@nokia.com>
On Wed, 8 Sep 2010 09:03:09 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> On Wednesday 08 September 2010 06:23:43 ext G, Manjunath Kondaiah wrote:
> > This patch fixes sparse warning due non declaration of static function
> >
> > sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol
> > 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
> >
> > Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> > Cc: alsa-devel@alsa-project.org
> > Cc: Jarkko Nikula <jhnikula@gmail.com>
> > Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> > Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Nishanth Menon <nm@ti.com>
>
> The patch name could be ASoC: omap-mcbsp: ...
>
> Other than that:
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Yep, name should start with ASoC.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2010-09-08 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 3:23 [PATCH] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
2010-09-08 6:03 ` Peter Ujfalusi
2010-09-08 7:28 ` Jarkko Nikula [this message]
2010-09-08 9:13 ` Mark Brown
2010-09-08 11:14 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908102836.04e64383.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=manjugk@ti.com \
--cc=nm@ti.com \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox