* [PATCH] OMAP: McBSP: Fix static function warning
@ 2010-09-08 3:23 G, Manjunath Kondaiah
2010-09-08 6:03 ` Peter Ujfalusi
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-08 3:23 UTC (permalink / raw)
To: linux-omap
Cc: alsa-devel, Jarkko Nikula, Peter Ujfalusi, Liam Girdwood,
Mark Brown, Tony Lindgren, Nishanth Menon
This patch fixes sparse warning due non declaration of static function
sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
Cc: alsa-devel@alsa-project.org
Cc: Jarkko Nikula <jhnikula@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
sound/soc/omap/omap-mcbsp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 86f2139..5768381 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -780,7 +780,7 @@ struct snd_soc_dai omap_mcbsp_dai[] = {
EXPORT_SYMBOL_GPL(omap_mcbsp_dai);
-int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
+static int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_info *uinfo)
{
struct soc_mixer_control *mc =
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: McBSP: Fix static function warning
2010-09-08 3:23 [PATCH] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
@ 2010-09-08 6:03 ` Peter Ujfalusi
2010-09-08 7:28 ` Jarkko Nikula
2010-09-08 9:13 ` Mark Brown
2010-09-08 11:14 ` Liam Girdwood
2 siblings, 1 reply; 5+ messages in thread
From: Peter Ujfalusi @ 2010-09-08 6:03 UTC (permalink / raw)
To: ext G, Manjunath Kondaiah
Cc: Nishanth Menon, alsa-devel@alsa-project.org, Tony Lindgren,
Mark Brown, linux-omap@vger.kernel.org, Liam Girdwood
On Wednesday 08 September 2010 06:23:43 ext G, Manjunath Kondaiah wrote:
> This patch fixes sparse warning due non declaration of static function
>
> sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol
> 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
>
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: alsa-devel@alsa-project.org
> Cc: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
The patch name could be ASoC: omap-mcbsp: ...
Other than that:
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: McBSP: Fix static function warning
2010-09-08 6:03 ` Peter Ujfalusi
@ 2010-09-08 7:28 ` Jarkko Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2010-09-08 7:28 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: Nishanth Menon, alsa-devel@alsa-project.org, Tony Lindgren,
ext G, Manjunath Kondaiah, Mark Brown, linux-omap@vger.kernel.org,
Liam Girdwood
On Wed, 8 Sep 2010 09:03:09 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> On Wednesday 08 September 2010 06:23:43 ext G, Manjunath Kondaiah wrote:
> > This patch fixes sparse warning due non declaration of static function
> >
> > sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol
> > 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
> >
> > Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> > Cc: alsa-devel@alsa-project.org
> > Cc: Jarkko Nikula <jhnikula@gmail.com>
> > Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> > Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Nishanth Menon <nm@ti.com>
>
> The patch name could be ASoC: omap-mcbsp: ...
>
> Other than that:
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Yep, name should start with ASoC.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: McBSP: Fix static function warning
2010-09-08 3:23 [PATCH] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
2010-09-08 6:03 ` Peter Ujfalusi
@ 2010-09-08 9:13 ` Mark Brown
2010-09-08 11:14 ` Liam Girdwood
2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2010-09-08 9:13 UTC (permalink / raw)
To: G, Manjunath Kondaiah
Cc: linux-omap, alsa-devel, Jarkko Nikula, Peter Ujfalusi,
Liam Girdwood, Tony Lindgren, Nishanth Menon
On Wed, Sep 08, 2010 at 08:53:43AM +0530, G, Manjunath Kondaiah wrote:
> This patch fixes sparse warning due non declaration of static function
>
> sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: McBSP: Fix static function warning
2010-09-08 3:23 [PATCH] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
2010-09-08 6:03 ` Peter Ujfalusi
2010-09-08 9:13 ` Mark Brown
@ 2010-09-08 11:14 ` Liam Girdwood
2 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-09-08 11:14 UTC (permalink / raw)
To: G, Manjunath Kondaiah
Cc: Nishanth Menon, alsa-devel, Tony Lindgren, Mark Brown,
Peter Ujfalusi, linux-omap
On Wed, 2010-09-08 at 08:53 +0530, G, Manjunath Kondaiah wrote:
> This patch fixes sparse warning due non declaration of static function
>
> sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
>
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: alsa-devel@alsa-project.org
> Cc: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
>
> ---
> sound/soc/omap/omap-mcbsp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
> index 86f2139..5768381 100644
> --- a/sound/soc/omap/omap-mcbsp.c
> +++ b/sound/soc/omap/omap-mcbsp.c
> @@ -780,7 +780,7 @@ struct snd_soc_dai omap_mcbsp_dai[] = {
>
> EXPORT_SYMBOL_GPL(omap_mcbsp_dai);
>
> -int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
> +static int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
> struct snd_ctl_elem_info *uinfo)
> {
> struct soc_mixer_control *mc =
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-09-08 11:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-08 3:23 [PATCH] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
2010-09-08 6:03 ` Peter Ujfalusi
2010-09-08 7:28 ` Jarkko Nikula
2010-09-08 9:13 ` Mark Brown
2010-09-08 11:14 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox