From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] OMAP: McBSP: Fix static function warning Date: Wed, 8 Sep 2010 10:28:36 +0300 Message-ID: <20100908102836.04e64383.jhnikula@gmail.com> References: <1283916223-23567-1-git-send-email-manjugk@ti.com> <201009080903.09652.peter.ujfalusi@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201009080903.09652.peter.ujfalusi@nokia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Ujfalusi Cc: Nishanth Menon , "alsa-devel@alsa-project.org" , Tony Lindgren , "ext G, Manjunath Kondaiah" , Mark Brown , "linux-omap@vger.kernel.org" , Liam Girdwood List-Id: linux-omap@vger.kernel.org On Wed, 8 Sep 2010 09:03:09 +0300 Peter Ujfalusi wrote: > On Wednesday 08 September 2010 06:23:43 ext G, Manjunath Kondaiah wrote: > > This patch fixes sparse warning due non declaration of static function > > > > sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol > > 'omap_mcbsp_st_info_volsw' was not declared. Should it be static? > > > > Signed-off-by: G, Manjunath Kondaiah > > Cc: alsa-devel@alsa-project.org > > Cc: Jarkko Nikula > > Cc: Peter Ujfalusi > > Cc: Liam Girdwood > > Cc: Mark Brown > > Cc: Tony Lindgren > > Cc: Nishanth Menon > > The patch name could be ASoC: omap-mcbsp: ... > > Other than that: > > Acked-by: Peter Ujfalusi Yep, name should start with ASoC. Acked-by: Jarkko Nikula