From: Tony Lindgren <tony@atomide.com>
To: David Cross <david.cross@cypress.com>
Cc: 'Greg KH' <greg@kroah.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] gpmc, EXPORT_SYMBOLS, west bridge related
Date: Wed, 8 Sep 2010 10:30:40 -0700 [thread overview]
Message-ID: <20100908173040.GP22507@atomide.com> (raw)
In-Reply-To: <701AE2655D844F9AAB5F2492AD477066@stanford.edu>
* David Cross <david.cross@cypress.com> [100908 09:52]:
>
> > From: Greg KH [mailto:greg@kroah.com]
>
> > On Tue, Sep 07, 2010 at 12:26:47PM -0700, David Cross wrote:
> > > This patch exports some of the gpmc driver functions in OMAP3. The
> purpose behind this patch
> > > is to allow device drivers compiled as loadable modules to be interfaced
> > to the GPMC. I am
> > > hoping that Tony is the correct maintainer and willing to ACK this
> change. Please let me know
> > > if there are any issues or concerns with this patch.
> > > Thanks,
> > > David
> > >
> > > Signed-off-by: David Cross <david.cross@cypress.com>
> > >
> > > diff -uprN -X linux-next-vanilla/Documentation/dontdiff
> linux-next-vanilla/arch/arm/mach-omap2/gpmc.c
> linux-next-incl-sdk/arch/arm/mach-omap2/gpmc.c
> > > --- linux-next-vanilla/arch/arm/mach-omap2/gpmc.c 2010-08-31
> 19:32:51.000000000 -0700
> > > +++ linux-next-incl-sdk/arch/arm/mach-omap2/gpmc.c 2010-09-01
> 16:10:21.000000000 -0700
> > > @@ -133,6 +133,7 @@ void gpmc_cs_write_reg(int cs, int idx,
> > > reg_addr = gpmc_base + GPMC_CS0_OFFSET + (cs * GPMC_CS_SIZE) + idx;
> > > __raw_writel(val, reg_addr);
> > > }
> > > +EXPORT_SYMBOL(gpmc_cs_write_reg);
>
> > EXPORT_SYMBOL_GPL() perhaps?
>
> I don't have an issue with that, though I am not sure I understand why we
> would want to limit the usage of the function to GPL'd modules. It is
> probably Tony's call assuming he is ok with exporting the symbol.
Exporting these is not a good idea, it should be done in the platform
init code like I replied in another message.
Regards,
Tony
next prev parent reply other threads:[~2010-09-08 17:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 19:26 [PATCH] gpmc, EXPORT_SYMBOLS, west bridge related David Cross
2010-09-07 23:58 ` Greg KH
2010-09-08 17:00 ` David Cross
2010-09-08 17:30 ` Tony Lindgren [this message]
2010-09-08 17:28 ` Tony Lindgren
2010-09-09 3:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908173040.GP22507@atomide.com \
--to=tony@atomide.com \
--cc=david.cross@cypress.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).