From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Keerthy <j-keerthy@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"balajitk@ti.com" <balajitk@ti.com>
Subject: Re: [lm-sensors] [PATCH 2/2] Makefile and Kconfig changes for twl4030-madc driver
Date: Thu, 16 Sep 2010 07:06:17 -0700 [thread overview]
Message-ID: <20100916140617.GA14165@ericsson.com> (raw)
In-Reply-To: <1284632612-25339-1-git-send-email-j-keerthy@ti.com>
On Thu, Sep 16, 2010 at 06:23:32AM -0400, Keerthy wrote:
> Makefile amd Kconfig Changes for twl4030-madc driver inclusion.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/mach-omap2/Kconfig | 4 ++++
> drivers/hwmon/Kconfig | 4 ++++
> drivers/hwmon/Makefile | 1 +
> 3 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index b48bacf..139137b 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -170,6 +170,8 @@ config MACH_OMAP_3430SDP
> depends on ARCH_OMAP3
> default y
> select OMAP_PACKAGE_CBB
> + select HWMON
> + select TWL4030_MADC
>
> config MACH_NOKIA_N800
> bool
> @@ -206,6 +208,8 @@ config MACH_OMAP_ZOOM3
> depends on ARCH_OMAP3
> default y
> select OMAP_PACKAGE_CBP
> + select HWMON
> + select TWL4030_MADC
>
> config MACH_CM_T35
> bool "CompuLab CM-T35 module"
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
While it may make sense to have the above changes in a separate patch,
the two files below should be part of patch #1, since they
are logically part of the driver, and the driver itself won't
make any sense in the code without being enabled in Kconfig/Makefile.
> index 4d4d09b..47d66b9 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -39,6 +39,10 @@ config HWMON_DEBUG_CHIP
>
> comment "Native drivers"
>
> +config TWL4030_MADC
Please use SENSORS_TWL4030_MADC or SENSORS_TWL4030 to be in line
with all other definitions. Also, please retain alphabetical order.
> + tristate
> + depends on HWMON && TWL4030_CORE
> +
HWMON is really redundant here and should be removed.
> config SENSORS_ABITUGURU
> tristate "Abit uGuru (rev 1 & 2)"
> depends on X86 && EXPERIMENTAL
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index e3c2484..24b3b17 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -16,6 +16,7 @@ obj-$(CONFIG_SENSORS_W83792D) += w83792d.o
> obj-$(CONFIG_SENSORS_W83793) += w83793.o
> obj-$(CONFIG_SENSORS_W83781D) += w83781d.o
> obj-$(CONFIG_SENSORS_W83791D) += w83791d.o
> +obj-$(CONFIG_TWL4030_MADC) += twl4030-madc.o
>
Again, please retain alphabetical order. There is a reason for the other sensors
to be out of order (see comments in the Makefile), but presumably that does
not apply this one. If it does, please add comment/reason indicating that/if
this is the case.
> obj-$(CONFIG_SENSORS_ABITUGURU) += abituguru.o
> obj-$(CONFIG_SENSORS_ABITUGURU3)+= abituguru3.o
> --
> 1.7.0.4
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-09-16 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 10:23 [PATCH 2/2] Makefile and Kconfig changes for twl4030-madc driver Keerthy
2010-09-16 14:06 ` Guenter Roeck [this message]
2010-09-20 10:31 ` [lm-sensors] " J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916140617.GA14165@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=balajitk@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).