From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Subject: Re: [PATCH v2 08/10] TWL IRQ: Fix fucntion declaration warnings Date: Mon, 27 Sep 2010 13:16:10 +0200 Message-ID: <20100927111609.GF2560@sortiz-mobl> References: <1285063280-4057-1-git-send-email-manjugk@ti.com> <1285063280-4057-9-git-send-email-manjugk@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:17345 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755557Ab0I0LPw (ORCPT ); Mon, 27 Sep 2010 07:15:52 -0400 Content-Disposition: inline In-Reply-To: <1285063280-4057-9-git-send-email-manjugk@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "G, Manjunath Kondaiah" Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Nishanth Menon Hi Manjunath, On Tue, Sep 21, 2010 at 03:31:18PM +0530, G, Manjunath Kondaiah wrote: > Fixes following sparse warnings for twl4030 and twl6030 irq files. > > drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static? > drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not declared. Should it be static? > drivers/mfd/twl4030-irq.c:873:5: warning: symbol 'twl4030_init_chip_irq' was not declared. Should it be static? > > drivers/mfd/twl6030-irq.c:226:5: warning: symbol 'twl6030_init_irq' was not declared. Should it be static? > drivers/mfd/twl6030-irq.c:290:5: warning: symbol 'twl6030_exit_irq' was not declared. Should it be static? > > Signed-off-by: G, Manjunath Kondaiah > Cc: linux-arm-kernel@lists.infradead.org > Cc: Samuel Ortiz > Cc: Tony Lindgren > Cc: Nishanth Menon > --- > include/linux/i2c/twl.h | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h > index 6de90bf..c61e90a 100644 > --- a/include/linux/i2c/twl.h > +++ b/include/linux/i2c/twl.h > @@ -172,6 +172,11 @@ int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes); > > int twl6030_interrupt_unmask(u8 bit_mask, u8 offset); > int twl6030_interrupt_mask(u8 bit_mask, u8 offset); > +int twl6030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end); > +int twl6030_exit_irq(void); > +int twl4030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end); > +int twl4030_exit_irq(void); > +int twl4030_init_chip_irq(const char *chip); No, we don't want to export those. Try defining them as extern from twl*-irq.c. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/