From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Subject: Re: [PATCH v2 08/10] TWL IRQ: Fix fucntion declaration warnings Date: Mon, 27 Sep 2010 16:46:11 +0200 Message-ID: <20100927144610.GH2560@sortiz-mobl> References: <1285063280-4057-1-git-send-email-manjugk@ti.com> <1285063280-4057-9-git-send-email-manjugk@ti.com> <20100927111609.GF2560@sortiz-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga11.intel.com ([192.55.52.93]:29047 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755783Ab0I0Opu (ORCPT ); Mon, 27 Sep 2010 10:45:50 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "G, Manjunath Kondaiah" Cc: "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Tony Lindgren , "Menon, Nishanth" Hi Manjunath, On Mon, Sep 27, 2010 at 07:19:33PM +0530, G, Manjunath Kondaiah wrote: > > > No, we don't want to export those. Try defining them as extern from > > > twl*-irq.c. > > > > Having extern in .c file will generate checkpatch warning as: > > WARNING: externs should be avoided in .c files > > As an alternate, how about having twl-core.h in drivers/mfd and defining them > as extern so that these API's will be available only to files under drivers/mfd? > That would be better, yes. Even though exporting those definititions through linux/i2c/twl.h is harmless. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/