linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [RFC 1/5] OMAP: mux: Add support for control module split in several partitions
Date: Mon, 27 Sep 2010 08:46:11 -0700	[thread overview]
Message-ID: <20100927154611.GT4211@atomide.com> (raw)
In-Reply-To: <20100925002228.GP4211@atomide.com>

* Tony Lindgren <tony@atomide.com> [100924 17:14]:
> 
> * Benoit Cousson <b-cousson@ti.com> [100924 02:07]:
> 
> If we wanted to use only the offset in the data, we could initialize
> the various sections separately. But then omapX_mux_init() would have
> to know the partition number somehow..

After thinking about this a bit more, to me it seems like this is
the best way to go. Then there's no need to repeat the partition data
for each entry. How about this:

Earlier defines stay the same:

#define OMAP3_MUX(mode0, mux_value)					\
{									\
	.reg_offset	= (OMAP3_CONTROL_PADCONF_##mode0##_OFFSET),	\
	.value		= (mux_value),					\
}

Then for omap4, we need to add a separate board mux table for each
partition:

#define OMAP4_MUX_PARTXXX(mode0, mux_value)				\
{									\
	.reg_offset	= (OMAP4_PART_XXX_PADCONF_##mode0##_OFFSET),	\
	.value		= (mux_value),					\
}

#define OMAP4_MUX_PARTYYY(mode0, mux_value)				\
{									\
	.reg_offset	= (OMAP4_PARTYYY_PADCONF_##mode0##_OFFSET),	\
	.value		= (mux_value),					\
}
...

For omap2 and 3, we just call omap_mux_init once with the mux_pbase
as we currently already do. Then for omap4, we call omap_mux_init for
each partition.

We also need to change omap_mux_read/write to allow specifying the
partition base address:

u16 omap_mux_read(void __iomem *base, u16 offset)
{
	if (cpu_is_omap24xx())
		return __raw_readb(base + offset);
	else
		return __raw_readw(base + offset);
}

All the other mux interface functions can stay the same, we just need
to modify the mux.c code to look for signal names or GPIO number in
each registered partition.

Regards,

Tony

  reply	other threads:[~2010-09-27 15:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24  9:15 [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support Benoit Cousson
2010-09-24  9:15 ` [RFC 1/5] OMAP: mux: Add support for control module split in several partitions Benoit Cousson
2010-09-25  0:22   ` Tony Lindgren
2010-09-27 15:46     ` Tony Lindgren [this message]
2010-09-27 17:24       ` Cousson, Benoit
2010-09-27 17:36         ` Tony Lindgren
2010-09-27 20:03           ` Cousson, Benoit
2010-09-27 20:06             ` Tony Lindgren
2010-09-24  9:15 ` [RFC 2/5] OMAP: mux: Make low level function private Benoit Cousson
2010-09-24 23:09   ` Gadiyar, Anand
2010-09-24 23:50     ` Tim Nordell
2010-09-25  0:07       ` Anand Gadiyar
2010-09-25  6:48         ` Tim Nordell
2010-09-24  9:15 ` [RFC 3/5] OMAP4: mux: Add data for OMAP4430 ES1 Benoit Cousson
2010-09-24 23:18   ` Anand Gadiyar
2010-09-27  9:31     ` Cousson, Benoit
2010-09-24  9:15 ` [RFC 4/5] OMAP4: mux: Select CBL package for SDP4430 with ES1 Benoit Cousson
2010-09-24 23:14   ` Anand Gadiyar
2010-09-27  7:24     ` Cousson, Benoit
2010-09-24  9:15 ` [RFC 5/5] OMAP4: mux: Temporary initial SDP4430 mux settings Benoit Cousson
2010-10-18 18:09 ` [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support Menon, Nishanth
2010-10-18 20:51   ` Cousson, Benoit
2010-10-18 20:53     ` Menon, Nishanth
2010-10-18 20:57       ` Cousson, Benoit
2010-10-18 21:08         ` Menon, Nishanth
2010-10-18 23:00     ` Tony Lindgren
2010-10-18 23:12       ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100927154611.GT4211@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).