From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 05/11] omap3: Remove non-existent config option Date: Mon, 27 Sep 2010 09:24:20 -0700 Message-ID: <20100927162420.GU4211@atomide.com> References: <20100924014938.10325.35279.stgit@baageli.muru.com> <20100924015056.10325.95854.stgit@baageli.muru.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:58622 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933211Ab0I0QYV (ORCPT ); Mon, 27 Sep 2010 12:24:21 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Contreras Cc: "Marathe, Yogesh" , "Premi, Sanjeev" , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" * Felipe Contreras [100927 08:47]: > On Mon, Sep 27, 2010 at 2:02 PM, Marathe, Yogesh wrote: > >> When you merge iommu support, then either you enable > >> CONFIG_MPU_BRIDGE_IOMMU unconditionally, or you apply this patch, but > >> this patch alone will only break things. > > > > Any other driver which does not depend on bridge and interested in using iommu should get the handle when iommu_get("iva2") is called. > > That's a hypothetical driver, right? The only driver that would ever > be interested in the "iva2" iommu is tidspbridge, and this patch would > brake it. > > > It is not happening in original case. I think there should not be restrictions on other drivers to define un-related compile time define if they just want to use iommu driver. I feel the implementation that is breaking due to removal of this define should be fixed. > > I couldn't parse that correctly. However, what's wrong with the > proposal? Let's think about CONFIG_MPU_BRIDGE_IOMMU when the iommu > patches come. Let's not break the existing code. Dropping this patch for now. Tony