[PATCH] staging: tidspbridge: disable all peripherals at bridge_brd_stop

[PATCH] staging: tidspbridge: disable all peripherals at bridge_brd_stop

[Ernesto Ramos]

DSP Bridge needs to disable the peripheral clocks when switches to
BRD_STOPPED since that would prevent the domain to enter in OFF state.

Signed-off-by: Ernesto Ramos <ernesto@ti.com>
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
 drivers/staging/tidspbridge/core/tiomap3430.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c
index 0e3558a..8b73ac9 100644
--- a/drivers/staging/tidspbridge/core/tiomap3430.c
+++ b/drivers/staging/tidspbridge/core/tiomap3430.c
@@ -552,7 +552,7 @@ static int bridge_brd_stop(struct bridge_dev_context *dev_ctxt)
 	int status = 0;
 	struct bridge_dev_context *dev_context = dev_ctxt;
 	u32 dsp_pwr_state;
-	int clk_status, i;
+	int i;
 	struct bridge_ioctl_extproc *tlb = dev_context->atlb_entry;
 	struct dspbridge_platform_data *pdata =
 				omap_dspbridge_dev->dev.platform_data;
@@ -621,7 +621,8 @@ static int bridge_brd_stop(struct bridge_dev_context *dev_ctxt)
 	(*pdata->dsp_prm_rmw_bits)(OMAP3430_RST2_IVA2_MASK,
 		OMAP3430_RST2_IVA2_MASK, OMAP3430_IVA2_MOD, OMAP2_RM_RSTCTRL);
 
-	clk_status = dsp_clk_disable(DSP_CLK_IVA2);
+	dsp_clock_disable_all(dev_context->dsp_per_clks);
+	dsp_clk_disable(DSP_CLK_IVA2);
 
 	return status;
 }
-- 
1.5.4.5

Re: [PATCH] staging: tidspbridge: disable all peripherals at bridge_brd_stop

[Greg KH]

On Fri, Sep 24, 2010 at 04:02:03PM -0500, Ernesto Ramos wrote:
> DSP Bridge needs to disable the peripheral clocks when switches to
> BRD_STOPPED since that would prevent the domain to enter in OFF state.
> 
> Signed-off-by: Ernesto Ramos <ernesto@ti.com>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>

This patch doesn't apply to the latest linux-next tree, what did you
make it against?

Care to fix it up and resend it?

thanks,

greg k-h

[PATCH] staging: tidspbridge: disable all peripherals at bridge_brd_stop

[Ernesto Ramos]

DSP Bridge needs to disable the peripheral clocks when switches to
BRD_STOPPED since that would prevent the domain to enter in OFF state.

Signed-off-by: Ernesto Ramos <ernesto@ti.com>
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
 drivers/staging/tidspbridge/core/tiomap3430.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c
index f1e59e8..e32e98a 100644
--- a/drivers/staging/tidspbridge/core/tiomap3430.c
+++ b/drivers/staging/tidspbridge/core/tiomap3430.c
@@ -625,7 +625,6 @@ static int bridge_brd_stop(struct bridge_dev_context *dev_ctxt)
 	struct bridge_dev_context *dev_context = dev_ctxt;
 	struct pg_table_attrs *pt_attrs;
 	u32 dsp_pwr_state;
-	int clk_status;
 	struct dspbridge_platform_data *pdata =
 				omap_dspbridge_dev->dev.platform_data;
 
@@ -679,7 +678,8 @@ static int bridge_brd_stop(struct bridge_dev_context *dev_ctxt)
 	(*pdata->dsp_prm_write)(OMAP3430_RST1_IVA2_MASK | OMAP3430_RST2_IVA2_MASK |
 			OMAP3430_RST3_IVA2_MASK, OMAP3430_IVA2_MOD, OMAP2_RM_RSTCTRL);
 
-	clk_status = dsp_clk_disable(DSP_CLK_IVA2);
+	dsp_clock_disable_all(dev_context->dsp_per_clks);
+	dsp_clk_disable(DSP_CLK_IVA2);
 
 	return status;
 }
-- 
1.5.4.5