From: Jarkko Nikula <jhnikula@gmail.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"Menon, Nishanth" <nm@ti.com>, Tony Lindgren <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish
Date: Fri, 1 Oct 2010 14:43:45 +0300 [thread overview]
Message-ID: <20101001144345.d5225789.jhnikula@gmail.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402DB90C3A9@dbde02.ent.ti.com>
On Fri, 1 Oct 2010 16:39:42 +0530
"G, Manjunath Kondaiah" <manjugk@ti.com> wrote:
> > On Friday 01 October 2010 12:29:54 ext G, Manjunath Kondaiah wrote:
> > > > But yes, it would make the code much more readable, and we can
> > > > easily track, which errata has been already addressed.
> > >
> > > This is already done as a part of dma hwmod which is under review.
> >
> > OK, so we shall not bother with this in the 'legacy' code, right?
> >
>
> That's correct but these patches needs to be ported on top of dma
> driver with hwmod changes.
>
Priority must be opposite. Hwmod change is upcoming cleanup but these
two patches are fixing existing problem.
Problem has been there probably quite some time but we were able to see
it only after a proper use-case. Which is buffer overrun when doing
audio recording only and after the commit c12abc0 (in 2.6.32).
--
Jarkko
next prev parent reply other threads:[~2010-10-01 11:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 6:39 [PATCH 0/2] OMAP2/3: DMA: FIFO drain errata fixes Peter Ujfalusi
2010-10-01 6:39 ` [PATCH 1/2] omap: dma: Fix buffering disable bit setting for omap24xx Peter Ujfalusi
2010-10-01 7:47 ` Nishanth Menon
2010-10-01 9:20 ` Jarkko Nikula
2010-10-01 6:39 ` [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish Peter Ujfalusi
2010-10-01 7:00 ` Jarkko Nikula
2010-10-01 7:45 ` Nishanth Menon
2010-10-01 8:51 ` Peter Ujfalusi
2010-10-01 9:23 ` Nishanth Menon
2010-10-01 10:40 ` Peter Ujfalusi
2010-10-01 9:29 ` G, Manjunath Kondaiah
2010-10-01 9:43 ` Nishanth Menon
2010-10-01 9:45 ` G, Manjunath Kondaiah
2010-10-01 10:43 ` Peter Ujfalusi
2010-10-01 10:41 ` Peter Ujfalusi
2010-10-01 11:09 ` G, Manjunath Kondaiah
2010-10-01 11:43 ` Jarkko Nikula [this message]
2010-10-01 11:48 ` Jarkko Nikula
2010-10-01 17:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001144345.d5225789.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=manjugk@ti.com \
--cc=nm@ti.com \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox