Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: David Cohen <david.cohen@nokia.com>
Cc: Tony Lindgren <tony@atomide.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Jarkko Nikula <jhnikula@gmail.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish
Date: Fri, 1 Oct 2010 15:43:22 +0300	[thread overview]
Message-ID: <201010011543.22374.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20101001121716.GB12614@esdhcp036161.research.nokia.com>

On Friday 01 October 2010 15:17:16 David Cohen wrote:
> No problem with those two variables, but you're doing multiple
> assignments in one line. You could do something like this:
> 
> l = dma_read(OCP_SYSCONFIG);
> sys_cf = l;

I have sent the v3 with this fixed.

Thanks you,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-10-01 12:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-01 11:04 [PATCH v2 0/2] OMAP2/3: DMA: FIFO drain errata fixes Peter Ujfalusi
2010-10-01 11:04 ` [PATCH v2 1/2] omap: dma: Fix buffering disable bit setting for omap24xx Peter Ujfalusi
2010-10-01 11:04 ` [PATCH v2 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish Peter Ujfalusi
2010-10-01 11:50   ` David Cohen
2010-10-01 12:16     ` Peter Ujfalusi
2010-10-01 12:17       ` David Cohen
2010-10-01 12:43         ` Peter Ujfalusi [this message]
2010-10-01 12:24       ` Felipe Balbi
2010-10-01 12:30         ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010011543.22374.peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=david.cohen@nokia.com \
    --cc=jhnikula@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=nm@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox