From: Tony Lindgren <tony@atomide.com>
To: Enric Balletbo i Serra <eballetbo@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCHv2 1/6] omap3: Add external VBUS power switch and overcurrent detect on IGEP v2 board.
Date: Fri, 1 Oct 2010 12:59:45 -0700 [thread overview]
Message-ID: <20101001195945.GW3117@atomide.com> (raw)
In-Reply-To: <1285962353-9586-2-git-send-email-eballetbo@gmail.com>
* Enric Balletbo i Serra <eballetbo@gmail.com> [101001 12:37]:
> GPIO for various devices are missing from the board initialization.
> This patch adds support for the VBUS and over current gpios. Without this
> patch, input/outputs from these two sources are ignored.
>
> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
> ---
> arch/arm/mach-omap2/board-igep0020.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
> index 175f043..1052a63 100644
> --- a/arch/arm/mach-omap2/board-igep0020.c
> +++ b/arch/arm/mach-omap2/board-igep0020.c
> @@ -274,6 +274,20 @@ static int igep2_twl_gpio_setup(struct device *dev,
> igep2_vmmc1_supply.dev = mmc[0].dev;
> igep2_vmmc2_supply.dev = mmc[1].dev;
>
> + /*
> + * REVISIT: need ehci-omap hooks for external VBUS
> + * power switch and overcurrent detect
> + */
> + gpio_request(gpio + 1, "GPIO_EHCI_NOC");
> + gpio_direction_input(gpio + 1);
> +
> + /*
> + * TWL4030_GPIO_MAX + 0 == ledA, GPIO_USBH_CPEN
> + * (out, active low)
> + */
> + gpio_request(gpio + TWL4030_GPIO_MAX, 0);
> + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
> +
> return 0;
> };
Please check the result value.. gpio_request can fail.
Tony
next prev parent reply other threads:[~2010-10-01 19:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 19:45 [PATCHv2 0/6] omap3: Various fixes and improvements for IGEP v2 board Enric Balletbo i Serra
2010-10-01 19:45 ` [PATCHv2 1/6] omap3: Add external VBUS power switch and overcurrent detect on " Enric Balletbo i Serra
2010-10-01 19:59 ` Tony Lindgren [this message]
2010-10-01 19:45 ` [PATCHv2 2/6] omap3: fix and improve the LED handling " Enric Balletbo i Serra
2010-10-01 20:02 ` Tony Lindgren
2010-10-01 19:45 ` [PATCHv2 3/6] omap3: Introduce function to detect the IGEP v2 hardware revision Enric Balletbo i Serra
2010-10-04 4:49 ` Varadarajan, Charulatha
2010-10-01 19:45 ` [PATCHv2 4/6] omap3: Fix handling some GPIO's for WLAN-BT combo on IGEP v2 Enric Balletbo i Serra
2010-10-01 19:45 ` [PATCHv2 5/6] omap3: Add i2c eeprom driver to read EDID " Enric Balletbo i Serra
2010-10-04 4:51 ` Varadarajan, Charulatha
2010-10-01 19:45 ` [PATCHv2 6/6] omap3: Remove VMMC2 regulator " Enric Balletbo i Serra
2010-10-01 20:07 ` [PATCHv2 0/6] omap3: Various fixes and improvements for IGEP v2 board Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001195945.GW3117@atomide.com \
--to=tony@atomide.com \
--cc=eballetbo@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).