Re: [PATCH v6 7/8] OMAP4: Keyboard board support

Abraham Arce
2010-09-30T07:04:53Z

Hi Dmitry,

Dmitry Torokhov wrote:
> HI Abraham,
>
> On Thu, Sep 30, 2010 at 12:36:13AM -0500, Abraham Arce wrote:
>> From: Syed Rafiuddin <rafiuddin.syed@ti.com>
>>
>> Keyboard support for SDP OMAP4430
>>
>
> I think this would benefit from "const" sprinkled on it.

You mean?

-static int sdp4430_keymap[] = {
+static const int sdp4430_keymap[] = {

>
> BTW, I picked up patches 2, 3, 4, 5, 8 (all touching drivers/input).

Thanks!

Best Regards
Abraham