Re: [PATCH v6 7/8] OMAP4: Keyboard board support

Tony Lindgren
2010-10-01T23:14:17Z

* Kevin Hilman <khilman@deeprootsystems.com> [101001 15:57]:
> Tony Lindgren <tony@atomide.com> writes:
>
> > * Dmitry Torokhov <dmitry.torokhov@gmail.com> [100929 23:32]:
> >> HI Abraham,
> >>
> >> On Thu, Sep 30, 2010 at 12:36:13AM -0500, Abraham Arce wrote:
> >> > From: Syed Rafiuddin <rafiuddin.syed@ti.com>
> >> >
> >> > Keyboard support for SDP OMAP4430
> >> >
> >>
> >> I think this would benefit from "const" sprinkled on it.
> >>
> >> BTW, I picked up patches 2, 3, 4, 5, 8 (all touching drivers/input).
> >
> > Thanks, I'll take 1, 6 & 7.
>
> Dmitry,
>
> Can you please drop patch 8 (the pm runtime one.) As pointed out by
> Charu, with the proposed platform changes, this cannot work
> correctly with runtime PM.
>
> Tony, I also propose we don't merge the platform code yet either until
> Abraham can respond to the platform-specific issues and runtime PM
> issues.
>
> I'm fine with Dmitry merging the rest of the driver changes though.

OK, I'll drop 1, 6 & 7.

Merging the rest of the driver changes sounds good to me too,
that way there's no longer a build dependecy on the plat/omap4-keypad.h ;)

Tony