linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: David Anders <x0132446@ti.com>,
	kishore kadiyala <kishore.kadiyala@ti.com>
Cc: linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [PATCH 3/4] omap4: pandaboard: Adding card detect support for MMC1
Date: Wed, 6 Oct 2010 14:59:38 -0700	[thread overview]
Message-ID: <20101006215938.GB4859@atomide.com> (raw)
In-Reply-To: <1286399673-912-4-git-send-email-x0132446@ti.com>

* David Anders <x0132446@ti.com> [101006 14:06]:
> Adding card detect callback function and card detect configuration
> function for MMC1 Controller.

This one would be best merged into this patch from Kishore:

https://patchwork.kernel.org/patch/189952/

Kishore, care to update your patch with this one and then send
the updated version to Samuel? I think there may have been some
other pending comments too.

The other three look OK to me to queue.

Regards,

Tony

> 
> Signed-off-by: David Anders <x0132446@ti.com>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> ---
> 
> patch depends on https://patchwork.kernel.org/patch/189952/
> 
>  arch/arm/mach-omap2/board-omap4panda.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index 697c0bd..94e819c 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -77,9 +77,14 @@ static int omap4_twl6030_hsmmc_late_init(struct device *dev)
>  	struct omap_mmc_platform_data *pdata = dev->platform_data;
>  
>  	/* Setting MMC1 Card detect Irq */
> -	if (pdev->id == 0)
> +	if (pdev->id == 0) {
> +		ret = twl6030_mmc_card_detect_config();
> +		if (ret)
> +			pr_err("Failed configuring MMC1 card detect\n");
>  		pdata->slots[0].card_detect_irq = TWL6030_IRQ_BASE +
>  						MMCDETECT_INTR_OFFSET;
> +		pdata->slots[0].card_detect = twl6030_mmc_card_detect;
> +	}
>  	return ret;
>  }
>  
> -- 
> 1.7.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-10-06 21:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 21:14 [PATCH 0/4] omap4: pandaboard: machine cleanups David Anders
2010-10-06 21:14 ` [PATCH 1/4] omap4: pandaboard: remove unused hsmmc definition David Anders
2010-10-06 21:14 ` [PATCH 2/4] omap4: pandaboard: Fix the init if CONFIG_MMC_OMAP_HS is not set David Anders
2010-10-06 21:14 ` [PATCH 3/4] omap4: pandaboard: Adding card detect support for MMC1 David Anders
2010-10-06 21:57   ` Kevin Hilman
2010-10-06 21:59   ` Tony Lindgren [this message]
2010-10-06 21:14 ` [PATCH 4/4] omap4: pandaboard: enable the ehci port on pandaboard David Anders
2010-10-06 21:58   ` Kevin Hilman
2010-10-06 22:12 ` [PATCH 0/4] omap4: pandaboard: machine cleanups Kevin Hilman
  -- strict thread matches above, loose matches on Subject: below --
2010-10-06 21:12 David Anders
2010-10-06 21:12 ` [PATCH 3/4] omap4: pandaboard: Adding card detect support for MMC1 David Anders
2010-09-21 21:24 [PATCH 0/4] omap4: pandaboard: machine cleanups David Anders
2010-09-21 21:24 ` [PATCH 3/4] omap4: pandaboard: Adding card detect support for MMC1 David Anders
2010-09-22  7:28   ` Bryan Wu
2010-09-22  8:43     ` Gadiyar, Anand
2010-09-22 14:40       ` David Anders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101006215938.GB4859@atomide.com \
    --to=tony@atomide.com \
    --cc=gadiyar@ti.com \
    --cc=kishore.kadiyala@ti.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=x0132446@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).