From: Arnd Bergmann <arnd@arndb.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-arm <linux-arm-kernel@lists.infradead.org>,
linux-omap <linux-omap@vger.kernel.org>, Greg KH <greg@kroah.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 3/3] staging: tidspbridge: remove memory consistency from TODO list
Date: Mon, 11 Oct 2010 12:40:25 +0200 [thread overview]
Message-ID: <201010111240.25759.arnd@arndb.de> (raw)
In-Reply-To: <1286732440-28644-4-git-send-email-felipe.contreras@gmail.com>
On Sunday 10 October 2010, Felipe Contreras wrote:
> The mempool area is not handled by the kernel any more.
But tidspbridge still uses ioremap to set up the mapping for RAM,
even though it now is outside of the kernel linar mapping.
You should really only use ioremap on MMIO registers, nothing
else. These registers are marked as __iomem pointers and can only
be passed into functions that talk to the hardware like iowrite32
or writel, but not used like memory.
Please have a look at "sparse", which will warn about address space
violations among other things. The tidspbridge driver is full of them,
and you should fix the code that sparse warns about, which will
also show you all the places where ioremap is used incorrectly.
Arnd
next prev parent reply other threads:[~2010-10-11 10:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 17:40 [PATCH 0/3] staging: tidspbridge: fix ioremap() usage Felipe Contreras
2010-10-10 17:40 ` [PATCH 1/3] arm: mm: allow boards to fiddle with meminfo Felipe Contreras
2010-10-10 19:03 ` Russell King - ARM Linux
2010-10-10 19:37 ` Felipe Contreras
2010-10-10 17:40 ` [PATCH 2/3] omap: dsp: fix ioremap() usage Felipe Contreras
2010-10-10 20:17 ` Premi, Sanjeev
2010-10-10 20:39 ` Felipe Contreras
2010-10-11 15:15 ` Guzman Lugo, Fernando
2010-10-11 19:05 ` Felipe Contreras
2010-10-10 17:40 ` [PATCH 3/3] staging: tidspbridge: remove memory consistency from TODO list Felipe Contreras
2010-10-11 10:40 ` Arnd Bergmann [this message]
2010-10-11 11:16 ` Felipe Contreras
2010-10-11 14:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010111240.25759.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=felipe.contreras@gmail.com \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox