From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff Date: Tue, 19 Oct 2010 08:52:19 -0700 Message-ID: <20101019155219.GI4589@kroah.com> References: <1287482608-11320-1-git-send-email-felipe.contreras@gmail.com> <1287482608-11320-4-git-send-email-felipe.contreras@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1287482608-11320-4-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Contreras Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap , linux-main , Felipe Balbi , Tony Lindgren List-Id: linux-omap@vger.kernel.org On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: > Add missing dependencies, and remove redundant ones, and select sensible > defaults. > > Signed-off-by: Felipe Contreras > --- > drivers/mfd/Kconfig | 3 ++- > drivers/regulator/Kconfig | 1 + > drivers/usb/gadget/Kconfig | 3 +-- > drivers/usb/musb/Kconfig | 6 ++---- > drivers/usb/otg/Kconfig | 2 ++ > 5 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index db51ea1..0bbaf01 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -156,6 +156,7 @@ config MENELAUS > config TWL4030_CORE > bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support" > depends on I2C=y && GENERIC_HARDIRQS > + default y if ARCH_OMAP3 || ARCH_OMAP4 Sorry, but unless the driver is somehow required to keep the board from going up in a puff of smoke, a default should NEVER be y. Because of that, I can't take this patch. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html