From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 2/3] usb: trivial Kconfig cleanups Date: Tue, 19 Oct 2010 10:50:36 -0700 Message-ID: <20101019175036.GB4618@kroah.com> References: <1287482608-11320-1-git-send-email-felipe.contreras@gmail.com> <1287482608-11320-3-git-send-email-felipe.contreras@gmail.com> <20101019155109.GH4589@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from kroah.org ([198.145.64.141]:52482 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555Ab0JSR5I (ORCPT ); Tue, 19 Oct 2010 13:57:08 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Contreras Cc: linux-usb@vger.kernel.org, linux-omap , linux-main , Felipe Balbi , Tony Lindgren On Tue, Oct 19, 2010 at 08:15:19PM +0300, Felipe Contreras wrote: > On Tue, Oct 19, 2010 at 6:51 PM, Greg KH wrote: > > On Tue, Oct 19, 2010 at 01:03:27PM +0300, Felipe Contreras wrote: > >> Note: USB_GADGET_MUSB_HDRC is already defined in usb/gadget. > >> > >> Signed-off-by: Felipe Contreras > > > > Please describe _what_ trivial cleanups you did, and why you did them. > > Care to resend? > > How about: > Shuffle the code a bit so the description is at the top, remove > duplicated configs (USB_GADGET_MUSB_HDRC), 'default n' is redundant, > and USB_GADGET_SELECTED should go after USB_GADGET (on the appropriate > config). Sounds good, but you need to resend it with this information in it, not much I can do with it in an independant email. thanks, greg k-h