Re: [PATCH] PERF(kernel): Cleanup power events V2

Rafael J. Wysocki
2010-10-27T09:16:35Z

On Wednesday, October 27, 2010, Thomas Renninger wrote:
> On Tuesday 26 October 2010 08:57:01 pm Rafael J. Wysocki wrote:
> > On Tuesday, October 26, 2010, Thomas Renninger wrote:
> > > >
> > > > Ok, that's at least generic. Needs the review of Rafael, to determine
> > > > whether this state value is all we want to know when we enter suspend.
> > > He already gave an acked-by on this generic one here:
> > > Re: [PATCH 3/4] perf: add calls to suspend trace point
> > > Oh now, that was on the X86 specific part which depends on this one.
> > > One should expect that he's fine with the generic part as well then,
> > > but I agree that he should definitely have a look at this and sign it off.
> >
> > What patch exactly do you mean? I'm not quite sure from your comment above.
>
> Eh, Jean's patch, sorry about that.
> Needs a tiny change to use PWR_EVENT_EXIT instead of 0 with
> my new patch series:

No problem with that as far as I'm concerned.

Thanks,
Rafael

> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> CC: Thomas Renninger <trenn@suse.de>
> Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> ---
> kernel/power/suspend.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
> index 7335952..10cad5c 100644
> --- a/kernel/power/suspend.c
> +++ b/kernel/power/suspend.c
> @@ -22,6 +22,7 @@
> #include <linux/mm.h>
> #include <linux/slab.h>
> #include <linux/suspend.h>
> +#include <trace/events/power.h>
>
> #include "power.h"
>
> @@ -164,7 +165,9 @@ static int suspend_enter(suspend_state_t state)
> error = sysdev_suspend(PMSG_SUSPEND);
> if (!error) {
> if (!suspend_test(TEST_CORE) && pm_check_wakeup_events()) {
> + trace_machine_suspend(state);
> error = suspend_ops->enter(state);
> + trace_machine_suspend(0);
> events_check_enabled = false;
> }
> sysdev_resume();
>
>