Re: [PATCH] PERF(kernel): Cleanup power events V2

Rafael J. Wysocki
2010-10-26T19:08:23Z

On Tuesday, October 26, 2010, Pierre Tardy wrote:
> On Tue, Oct 26, 2010 at 12:58 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Tue, 2010-10-26 at 11:56 -0500, Pierre Tardy wrote:
> >>
> >> + trace_runtime_pm_usage(dev, atomic_read(&dev->power.usage_count)+1);
> >> atomic_inc(&dev->power.usage_count);
> >
> > That's terribly racy..
> >
> I know. I'm not proud of this.. As I said, this is preliminary patch.
> We dont really need to have this prev_usage. This is just for debug.
> It mayprobably endup with something like:
>
> atomic_inc(&dev->power.usage_count);
> + trace_power_device_usage(dev);

Well, please tell me what you're trying to achieve.

Thanks,
Rafael