From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Renninger Subject: Re: [PATCH] PERF(kernel): Cleanup power events V2 Date: Wed, 27 Oct 2010 02:00:56 +0200 Message-ID: <201010270200.57748.trenn@suse.de> References: <1287488171-25303-3-git-send-email-trenn@suse.de> <201010261348.49240.trenn@suse.de> <201010262057.02218.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from cantor.suse.de ([195.135.220.2]:49393 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760558Ab0J0AAz (ORCPT ); Tue, 26 Oct 2010 20:00:55 -0400 In-Reply-To: <201010262057.02218.rjw@sisk.pl> Content-Disposition: inline Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Rafael J. Wysocki" Cc: Ingo Molnar , Jean Pihet , Linus Torvalds , Andrew Morton , Thomas Gleixner , Masami Hiramatsu , Frank Eigler , Steven Rostedt , Kevin Hilman , Peter Zijlstra , linux-omap@vger.kernel.org, linux-pm@lists.linux-foundation.org, linux-trace-users@vger.kernel.org, Pierre Tardy , Frederic Weisbecker , Tejun Heo , Mathieu Desnoyers , Arjan van de Ven On Tuesday 26 October 2010 08:57:01 pm Rafael J. Wysocki wrote: > On Tuesday, October 26, 2010, Thomas Renninger wrote: > > > > > > Ok, that's at least generic. Needs the review of Rafael, to determine > > > whether this state value is all we want to know when we enter suspend. > > He already gave an acked-by on this generic one here: > > Re: [PATCH 3/4] perf: add calls to suspend trace point > > Oh now, that was on the X86 specific part which depends on this one. > > One should expect that he's fine with the generic part as well then, > > but I agree that he should definitely have a look at this and sign it off. > > What patch exactly do you mean? I'm not quite sure from your comment above. Eh, Jean's patch, sorry about that. Needs a tiny change to use PWR_EVENT_EXIT instead of 0 with my new patch series: Signed-off-by: Jean Pihet CC: Thomas Renninger Acked-by: Rafael J. Wysocki --- kernel/power/suspend.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 7335952..10cad5c 100644 --- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -22,6 +22,7 @@ #include #include #include +#include #include "power.h" @@ -164,7 +165,9 @@ static int suspend_enter(suspend_state_t state) error = sysdev_suspend(PMSG_SUSPEND); if (!error) { if (!suspend_test(TEST_CORE) && pm_check_wakeup_events()) { + trace_machine_suspend(state); error = suspend_ops->enter(state); + trace_machine_suspend(0); events_check_enabled = false; } sysdev_resume();