Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init

Kevin Hilman
2010-11-16T16:16:12Z

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

> On Tue, 16 Nov 2010 09:23:06 -0600
> Nishanth Menon <nm@ti.com> wrote:
>
>> my initial implementation had forced board files to call the
>> opp_init_table, then changed that here:
>> http://marc.info/?l=linux-omap&m=127431810922704&w=2
>> Kevin seemed happy with the change here:
>> http://marc.info/?l=linux-omap&m=127507237109393&w=2
>
> Ok, if Kevin is happy with this solution, fair enough. Sorry for the
> noise, and thanks for your answers.

Yes, I'm not a big fan of the init function called multiple times
either, but I really want to minimize what board files have to do.

Historically, we tend to add all the init functions to every board file,
and this is getting cumbersome to understand and maintain. What we need
is for common code to take care of sensible defaults for all boards, and
then only boards with non-default behavior have to have custom code.

Kevin