Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init

Thomas Petazzoni
2010-11-16T11:21:37Z

Hello,

On Mon, 15 Nov 2010 13:27:39 -0600
Nishanth Menon <nm@ti.com> wrote:

> + /*
> + * Allow multiple calls, but initialize only if not already initalized

Minor: s/initalized/initialized/.

> + * even if the previous call failed, coz, no reason we'd succeed again
> + */
> + if (omap_table_init)
> + return 0;
> + omap_table_init = 1;

Do we really need this ? I personaly don't really like this quite of
"Hey, I'm already initialized, let's do nothing silently then". Unless
there are strong reasons for which this function could be called twice,
I'd rather not have this, or turn this into a BUG_ON(omap_table_init ==
1).

Regards,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.