From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: omap4: hsmmc: Fix improper card detection while booting Date: Tue, 16 Nov 2010 10:08:33 -0800 Message-ID: <20101116180833.GX9264@atomide.com> References: <6576.10.24.255.17.1289812139.squirrel@dbdmail.itg.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:36203 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754817Ab0KPSIm (ORCPT ); Tue, 16 Nov 2010 13:08:42 -0500 Content-Disposition: inline In-Reply-To: <6576.10.24.255.17.1289812139.squirrel@dbdmail.itg.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: kishore kadiyala Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org * kishore kadiyala [101115 00:59]: > While booting OMAP4 ES2.0 boards, cards on MMC1 and MMC2 controllers > are not getting detected some times. > > During reset of command/data line, wrong pointer to base address > was passed while read operation to SYSCTL register, thus impacting > the updated reset logic. > Passing correct base address fixes the issue. > > Signed-off-by: Kishore Kadiyala > Acked-by: Felipie Balbi > Cc: Tony Lindgren > Cc: Chris Ball > Cc: Madhusudhan Chikkature Good find: Acked-by: Tony Lindgren > --- > drivers/mmc/host/omap_hsmmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 82a1079..5d46021 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1002,7 +1002,7 @@ static inline void omap_hsmmc_reset_controller_fsm(struct omap_hsmmc_host > *host, > * Monitor a 0->1 transition first > */ > if (mmc_slot(host).features & HSMMC_HAS_UPDATED_RESET) { > - while ((!(OMAP_HSMMC_READ(host, SYSCTL) & bit)) > + while ((!(OMAP_HSMMC_READ(host->base, SYSCTL) & bit)) > && (i++ < limit)) > cpu_relax(); > } > -- > 1.7.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html