* [PATCH] omap3: feature: fix OMAP3_IVA_MASK
@ 2010-11-05 16:05 Nishanth Menon
2010-11-16 21:27 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2010-11-05 16:05 UTC (permalink / raw)
To: linux-omap; +Cc: Arno Steffen
From: Arno Steffen <arno.steffen@googlemail.com>
OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
Signed-off-by: Arno Steffen <arno.steffen@googlemail.com>
---
Sending on behalf of Arno - he pointed at the change and everything
except for the patch ;)
Reported here:
http://marc.info/?l=linux-omap&m=128896969832702&w=2
arch/arm/mach-omap2/control.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
index b6c6b7c..5325297 100644
--- a/arch/arm/mach-omap2/control.h
+++ b/arch/arm/mach-omap2/control.h
@@ -309,7 +309,7 @@
#define FEAT_SGX_NONE 2
#define OMAP3_IVA_SHIFT 12
-#define OMAP3_IVA_MASK (1 << OMAP3_SGX_SHIFT)
+#define OMAP3_IVA_MASK (1 << OMAP3_IVA_SHIFT)
#define FEAT_IVA 0
#define FEAT_IVA_NONE 1
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] omap3: feature: fix OMAP3_IVA_MASK
2010-11-05 16:05 [PATCH] omap3: feature: fix OMAP3_IVA_MASK Nishanth Menon
@ 2010-11-16 21:27 ` Tony Lindgren
2010-11-17 11:35 ` Nishanth Menon
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2010-11-16 21:27 UTC (permalink / raw)
To: Nishanth Menon; +Cc: linux-omap, Arno Steffen
* Nishanth Menon <nm@ti.com> [101105 17:29]:
> From: Arno Steffen <arno.steffen@googlemail.com>
>
> OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
>
> Signed-off-by: Arno Steffen <arno.steffen@googlemail.com>
> ---
> Sending on behalf of Arno - he pointed at the change and everything
> except for the patch ;)
> Reported here:
> http://marc.info/?l=linux-omap&m=128896969832702&w=2
Hmm, until we have an official verbal-patch-to-unified-diff translator,
I guess the right thing to do here is to make it be:
From: Nishanth Menon <nm@ti.com>
OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
Reported-by: Arno Steffen <arno.steffen@googlemail.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Can you please repost or confirm that's OK for you?
Tony
> arch/arm/mach-omap2/control.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
> index b6c6b7c..5325297 100644
> --- a/arch/arm/mach-omap2/control.h
> +++ b/arch/arm/mach-omap2/control.h
> @@ -309,7 +309,7 @@
> #define FEAT_SGX_NONE 2
>
> #define OMAP3_IVA_SHIFT 12
> -#define OMAP3_IVA_MASK (1 << OMAP3_SGX_SHIFT)
> +#define OMAP3_IVA_MASK (1 << OMAP3_IVA_SHIFT)
> #define FEAT_IVA 0
> #define FEAT_IVA_NONE 1
>
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] omap3: feature: fix OMAP3_IVA_MASK
2010-11-16 21:27 ` Tony Lindgren
@ 2010-11-17 11:35 ` Nishanth Menon
0 siblings, 0 replies; 3+ messages in thread
From: Nishanth Menon @ 2010-11-17 11:35 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, Arno Steffen
Tony Lindgren wrote, on 11/16/2010 03:27 PM:
> * Nishanth Menon<nm@ti.com> [101105 17:29]:
>> From: Arno Steffen<arno.steffen@googlemail.com>
>>
>> OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
>>
>> Signed-off-by: Arno Steffen<arno.steffen@googlemail.com>
>> ---
>> Sending on behalf of Arno - he pointed at the change and everything
>> except for the patch ;)
>> Reported here:
>> http://marc.info/?l=linux-omap&m=128896969832702&w=2
>
> Hmm, until we have an official verbal-patch-to-unified-diff translator,
> I guess the right thing to do here is to make it be:
>
> From: Nishanth Menon<nm@ti.com>
>
> OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
>
> Reported-by: Arno Steffen<arno.steffen@googlemail.com>
> Signed-off-by: Nishanth Menon<nm@ti.com>
>
> Can you please repost or confirm that's OK for you?
I would prefer if Arno resubmit the patch under his name - but if he
cannot do so, I can take ownership.
Arno,
please comment.
>
> Tony
>
>> arch/arm/mach-omap2/control.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
>> index b6c6b7c..5325297 100644
>> --- a/arch/arm/mach-omap2/control.h
>> +++ b/arch/arm/mach-omap2/control.h
>> @@ -309,7 +309,7 @@
>> #define FEAT_SGX_NONE 2
>>
>> #define OMAP3_IVA_SHIFT 12
>> -#define OMAP3_IVA_MASK (1<< OMAP3_SGX_SHIFT)
>> +#define OMAP3_IVA_MASK (1<< OMAP3_IVA_SHIFT)
>> #define FEAT_IVA 0
>> #define FEAT_IVA_NONE 1
>>
>> --
>> 1.7.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-17 11:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-05 16:05 [PATCH] omap3: feature: fix OMAP3_IVA_MASK Nishanth Menon
2010-11-16 21:27 ` Tony Lindgren
2010-11-17 11:35 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox