[PATCH ] McBSP:Make the free variable update more readable

[PATCH ] McBSP:Make the free variable update more readable

[shubhrajyoti]

From: Shubhrajyoti D <shubhrajyoti@ti.com>

Using true/false instead of 1/0 to update the free variable.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
 arch/arm/plat-omap/mcbsp.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index eac4b97..07c0525 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -755,7 +755,7 @@ int omap_mcbsp_request(unsigned int id)
 		goto err_kfree;
 	}
 
-	mcbsp->free = 0;
+	mcbsp->free = false;
 	mcbsp->reg_cache = reg_cache;
 	spin_unlock(&mcbsp->lock);
 
@@ -815,7 +815,7 @@ err_clk_disable:
 	clk_disable(mcbsp->iclk);
 
 	spin_lock(&mcbsp->lock);
-	mcbsp->free = 1;
+	mcbsp->free = true;
 	mcbsp->reg_cache = NULL;
 err_kfree:
 	spin_unlock(&mcbsp->lock);
@@ -858,7 +858,7 @@ void omap_mcbsp_free(unsigned int id)
 	if (mcbsp->free)
 		dev_err(mcbsp->dev, "McBSP%d was not reserved\n", mcbsp->id);
 	else
-		mcbsp->free = 1;
+		mcbsp->free = true;
 	mcbsp->reg_cache = NULL;
 	spin_unlock(&mcbsp->lock);
 
@@ -1771,7 +1771,7 @@ static int __devinit omap_mcbsp_probe(struct platform_device *pdev)
 
 	spin_lock_init(&mcbsp->lock);
 	mcbsp->id = id + 1;
-	mcbsp->free = 1;
+	mcbsp->free = true;
 	mcbsp->dma_tx_lch = -1;
 	mcbsp->dma_rx_lch = -1;
 
-- 
1.7.0.4

Re: [PATCH ] McBSP:Make the free variable update more readable

[Jarkko Nikula]

On Wed,  3 Nov 2010 15:28:57 +0530
shubhrajyoti@ti.com wrote:

> From: Shubhrajyoti D <shubhrajyoti@ti.com>
> 
> Using true/false instead of 1/0 to update the free variable.
> 
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
>  arch/arm/plat-omap/mcbsp.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
Acked-by: Jarkko Nikula <jhnikula@gmail.com>

Re: [PATCH ] McBSP:Make the free variable update more readable

[Tony Lindgren]

* Jarkko Nikula <jhnikula@gmail.com> [101103 03:09]:
> On Wed,  3 Nov 2010 15:28:57 +0530
> shubhrajyoti@ti.com wrote:
> 
> > From: Shubhrajyoti D <shubhrajyoti@ti.com>
> > 
> > Using true/false instead of 1/0 to update the free variable.
> > 
> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> > ---
> >  arch/arm/plat-omap/mcbsp.c |   10 +++++-----
> >  1 files changed, 5 insertions(+), 5 deletions(-)
> > 
> Acked-by: Jarkko Nikula <jhnikula@gmail.com>

Next time, please also Cc linux-arm-kernel mailing list
for your arch/arm/*omap*/ touching patches. Otherwise
I have to repost before merging, which is not nice.

Anyways, queuing this for 2.6.38 merge window and will
repost to linux-arm-kernel along with other misc patches
at some point.

Tony

RE: [PATCH ] McBSP:Make the free variable update more readable

[Datta, Shubhrajyoti]

> -----Original Message-----
> From: Tony Lindgren [mailto:tony@atomide.com]
> Sent: Wednesday, November 17, 2010 3:06 AM
> To: Jarkko Nikula
> Cc: Datta, Shubhrajyoti; linux-omap@vger.kernel.org
> Subject: Re: [PATCH ] McBSP:Make the free variable update more readable
> 
> * Jarkko Nikula <jhnikula@gmail.com> [101103 03:09]:
> > On Wed,  3 Nov 2010 15:28:57 +0530
> > shubhrajyoti@ti.com wrote:
> >
> > > From: Shubhrajyoti D <shubhrajyoti@ti.com>
> > >
> > > Using true/false instead of 1/0 to update the free variable.
> > >
> > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> > > ---
> > >  arch/arm/plat-omap/mcbsp.c |   10 +++++-----
> > >  1 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > Acked-by: Jarkko Nikula <jhnikula@gmail.com>
> 
> Next time, please also Cc linux-arm-kernel mailing list
> for your arch/arm/*omap*/ touching patches. Otherwise
> I have to repost before merging, which is not nice.
> 
> Anyways, queuing this for 2.6.38 merge window and will
> repost to linux-arm-kernel along with other misc patches
> at some point.

I will make sure henceforth. 
Thanks,
> 
> Tony