From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Nishanth Menon <nm@ti.com>,
linux-omap <linux-omap@vger.kernel.org>, Tony <tony@atomide.com>
Subject: Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init
Date: Wed, 17 Nov 2010 09:19:16 +0100 [thread overview]
Message-ID: <20101117091916.48282778@surf> (raw)
In-Reply-To: <8762vxjlbs.fsf@deeprootsystems.com>
On Tue, 16 Nov 2010 08:16:07 -0800
Kevin Hilman <khilman@deeprootsystems.com> wrote:
> Yes, I'm not a big fan of the init function called multiple times
> either, but I really want to minimize what board files have to do.
>
> Historically, we tend to add all the init functions to every board
> file, and this is getting cumbersome to understand and maintain.
> What we need is for common code to take care of sensible defaults for
> all boards, and then only boards with non-default behavior have to
> have custom code.
The other way is to have the board code "register" its customization
into the OPP subsystem, and then when the OPP subsystem is initialized,
it takes those customizations into account. But in that specific case,
it's not clear how those customizations could easily be expressed, so
maybe that multiple call strategy is the simplest solution.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-11-17 8:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 0/3 v2] omap: opp: Add opp data>
2010-11-15 19:27 ` [PATCH v3 0/3] OMAP: Add opp data Nishanth Menon
2010-11-15 19:27 ` [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init Nishanth Menon
2010-11-15 22:51 ` Thomas Petazzoni
2010-11-16 0:53 ` Nishanth Menon
2010-11-16 20:35 ` Tony Lindgren
2010-11-16 21:11 ` Nishanth Menon
2010-11-16 11:21 ` Thomas Petazzoni
2010-11-16 11:54 ` Nishanth Menon
2010-11-16 12:42 ` Thomas Petazzoni
2010-11-16 13:10 ` Nishanth Menon
2010-11-16 13:20 ` Thomas Petazzoni
2010-11-16 14:02 ` Nishanth Menon
2010-11-16 15:23 ` Nishanth Menon
2010-11-16 15:50 ` Thomas Petazzoni
2010-11-16 15:56 ` Nishanth Menon
2010-11-16 16:16 ` Kevin Hilman
2010-11-16 20:37 ` Tony Lindgren
2010-11-17 8:19 ` Thomas Petazzoni [this message]
2010-11-15 19:27 ` [PATCH v3 2/3] omap4: opp: add OPP table data Nishanth Menon
2010-11-15 19:27 ` [PATCH v3 3/3] OMAP3: remove OPP interfaces from OMAP PM layer Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117091916.48282778@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox