From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4 Date: Fri, 19 Nov 2010 10:32:50 +0200 Message-ID: <20101119083250.GH6446@legolas.emea.dhcp.ti.com> References: <1290107742-16760-1-git-send-email-h-kanigeri2@ti.com> <1290107742-16760-3-git-send-email-h-kanigeri2@ti.com> <4CE5B68F.8000502@ti.com> Reply-To: balbi@ti.com Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:58047 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173Ab0KSIcs (ORCPT ); Fri, 19 Nov 2010 03:32:48 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Kanigeri, Hari" Cc: "Cousson, Benoit" , Hiroshi Doyu , linux omap , Tony Lindgren , Linux ARM On Thu, Nov 18, 2010 at 06:07:40PM -0600, Kanigeri, Hari wrote: >Benoit, > >On Thu, Nov 18, 2010 at 5:28 PM, Cousson, Benoit wr= ote: >> On 11/18/2010 8:15 PM, Hari Kanigeri wrote: >>> >>> disabling rx interrupt on omap4 is different than its pre-decessors= =2E >>> The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the >>> interrupts instead of clearing the bit. >>> >>> Signed-off-by: Hari Kanigeri >>> --- >>> =A0arch/arm/mach-omap2/mailbox.c | =A0 =A05 ++++- >>> =A01 files changed, 4 insertions(+), 1 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/ma= ilbox.c >>> index 42dbfa4..82b5ced 100644 >>> --- a/arch/arm/mach-omap2/mailbox.c >>> +++ b/arch/arm/mach-omap2/mailbox.c >>> @@ -195,7 +195,10 @@ static void omap2_mbox_disable_irq(struct omap= _mbox >>> *mbox, >>> =A0 =A0 =A0 =A0struct omap_mbox2_priv *p =3D (struct omap_mbox2_pri= v *)mbox->priv; >>> =A0 =A0 =A0 =A0u32 l, bit =3D (irq =3D=3D IRQ_TX) ? p->notfull_bit = : p->newmsg_bit; >>> =A0 =A0 =A0 =A0l =3D mbox_read_reg(p->irqdisable); >>> - =A0 =A0 =A0 l&=3D ~bit; >>> + =A0 =A0 =A0 if (cpu_is_omap44xx()) >> >> Since it is not omap version specific but IP version specific, you s= hould >> not use cpu_is_ to do that. Moreover cpu_is calls should be used dur= ing init >> only. >> You can use the rev field in hwmod_class in order to detect the IP v= ersion. >> Smartreflex series for 3630 is already using that kind of mechanism. >> You will have to copy that revision information into pdata struct an= d then >> use that here. > >I see your point, but since mailbox hwmod patches from Omar are still >under review I didn't find any other option than to enable this >This is critical functionality that I want to include in and not wait >till the hwmod patches are accepted. >Please let me know if there is any other way of approaching this probl= em ? how about you read the IP revision yourself during probe ? Or pass in a flag like I said on the other email ? --=20 balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html