Re: [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem

Mark Brown
2010-11-02T14:56:12Z

On Tue, Nov 02, 2010 at 03:50:32PM +0100, Janusz Krzysztofik wrote:
> In the new code introduced with commit cf4c87abe238ec17cd0255b4e21abd949d7f811e,
> "OMAP: McBSP: implement McBSP CLKR and FSR signal muxing via mach-omap2/mcbsp.c",
> the way omap1 build is supposed to bypass omap2 specific functionality doesn't
> optimize out all omap2 specific stuff. This breaks linking phase for omap1
> machines, giving "undefined reference to `omap2_mcbsp1_mux_clkr_src'"
> and "undefined reference to `omap2_mcbsp1_mux_fsr_src'" errors. Fix it.

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

> case OMAP_MCBSP_CLKR_SRC_CLKR:
> + if (cpu_class_is_omap1())
> + break;
> omap2_mcbsp1_mux_clkr_src(CLKR_SRC_CLKR);

I guess this will still fail with optimisation diabled, but I'm not sure
anyone ever builds the kernel like that.