Re: [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem

Paul Walmsley
2010-11-25T17:45:20Z

On Thu, 25 Nov 2010, Janusz Krzysztofik wrote:

> Thursday 25 November 2010 08:02:01 Jarkko Nikula wrote:
> > On Wed, 24 Nov 2010 15:53:42 -0800
> >
> > Tony Lindgren <tony@atomide.com> wrote:
> > > * Tony Lindgren <tony@atomide.com> [101124 15:25]:
> > > > Anyways, Paul's patch should be merged during the -rc cycle
> > > > because it is currently blocking Amstrad delta being built:
> > > >
> > > > http://armlinux.simtec.co.uk/kautobuild/
> > >
> > > Turns out I'm several hours behind.. The build is
> > > working with Janusz commit 233538501f707b0176f09af7039fec1e3fcac6e7
> > > now in mainline.
> > >
> > > I guess no need to merge Paul's fix then?
> >
> > Not necessary I think if compilers are happy with Janusz's fix. If not,
> > then very strong reasong to start looking for platform data solution
> > as soon as possible :-)
>
> Fine with me if you prefere reverting my changes and using Paul's fix as a
> better short term solution instead.

And I'm fine with Janusz's patch. My patch was written in response to
Mark's comments about compilers...

- Paul