From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Srikar <ext-srikar.1.bhavanarayana@nokia.com>
Cc: tony@atomide.com, linux@arm.linux.org.uk, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51
Date: Fri, 26 Nov 2010 12:59:49 +0000 [thread overview]
Message-ID: <20101126125949.GD30360@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4CEF8453.3070904@nokia.com>
On Fri, Nov 26, 2010 at 11:56:35AM +0200, Srikar wrote:
> On 11/25/2010 06:11 PM, ext Mark Brown wrote:
> > On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote:
> >
> >> +static struct regulator_consumer_supply rx51_vdac_supply[] = {
> >> + {
> >> +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
> > The ifdefs here aren't really saving much...
> Currently rx51_display_device is defined under same
> ifdefs(CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE)
> as extern and also in board-rx51-video.c display devices are under same
> ifdefs,So used to not
> break compilation when CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE not defined.
If you convert to usign dev_name as is better practice anyway this
won't be an issue.
> >> + .supply = "vdda_dac",
> >> + .dev = &rx51_display_device.dev,
> > dev_name is preferred, though I'm not sure if we'll ever get round to
> > phasing out plain dev.
> Currently difficult to use .dev_name .
because...
next prev parent reply other threads:[~2010-11-26 12:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 15:52 [PATCH 1/2] Added video data to support tvout on rx51 Srikar
2010-11-25 15:52 ` [PATCH 2/2] enabled vdda_dac regulator " Srikar
2010-11-25 16:11 ` Mark Brown
2010-11-26 9:42 ` ext-srikar.1.bhavanarayana
2010-11-26 9:56 ` Srikar
2010-11-26 12:59 ` Mark Brown [this message]
2010-11-26 17:45 ` Tony Lindgren
2010-11-27 10:20 ` Mark Brown
2010-11-29 18:18 ` Tony Lindgren
2010-11-29 18:37 ` Mark Brown
2010-11-30 17:39 ` Tony Lindgren
2010-12-22 11:51 ` Srikar
2010-12-18 0:42 ` [PATCH 1/2] Added video data to " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126125949.GD30360@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ext-srikar.1.bhavanarayana@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox