From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51
Date: Fri, 26 Nov 2010 12:59:49 +0000
Message-ID: <20101126125949.GD30360@rakim.wolfsonmicro.main>
References: <1290700343-26640-1-git-send-email-ext-srikar.1.bhavanarayana@nokia.com>
 <1290700343-26640-2-git-send-email-ext-srikar.1.bhavanarayana@nokia.com>
 <20101125161112.GB15099@sirena.org.uk>
 <4CEF8453.3070904@nokia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from opensource.wolfsonmicro.com ([80.75.67.52]:34301 "EHLO
	opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1754657Ab0KZM7v (ORCPT
	<rfc822;linux-omap@vger.kernel.org>);
	Fri, 26 Nov 2010 07:59:51 -0500
Content-Disposition: inline
In-Reply-To: <4CEF8453.3070904@nokia.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: Srikar <ext-srikar.1.bhavanarayana@nokia.com>
Cc: tony@atomide.com, linux@arm.linux.org.uk, linux-omap@vger.kernel.org

On Fri, Nov 26, 2010 at 11:56:35AM +0200, Srikar wrote:
> On 11/25/2010 06:11 PM, ext Mark Brown wrote:
> > On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote:
> >
> >> +static struct regulator_consumer_supply rx51_vdac_supply[] = {
> >> +	{
> >> +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
> > The ifdefs here aren't really saving much...

> Currently rx51_display_device is defined under same
> ifdefs(CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE)
>  as extern and also in board-rx51-video.c display devices are under same
> ifdefs,So used to  not
> break compilation when CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE not defined.

If you convert to usign dev_name as is better practice anyway this
won't be an issue.

> >> +		.supply	= "vdda_dac",
> >> +		.dev	= &rx51_display_device.dev,
> > dev_name is preferred, though I'm not sure if we'll ever get round to
> > phasing out plain dev.

> Currently difficult to use .dev_name .

because...