* [PATCH] OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
@ 2010-11-26 11:41 Arno Steffen
2010-11-29 14:29 ` Nishanth Menon
0 siblings, 1 reply; 3+ messages in thread
From: Arno Steffen @ 2010-11-26 11:41 UTC (permalink / raw)
To: linux-omap
Signed-off-by: Arno Steffen <arno.steffen@googlemail.com>
---
arch/arm/mach-omap2/control.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
index b6c6b7c..5325297 100644
--- a/arch/arm/mach-omap2/control.h
+++ b/arch/arm/mach-omap2/control.h
@@ -309,7 +309,7 @@
#define FEAT_SGX_NONE 2
#define OMAP3_IVA_SHIFT 12
-#define OMAP3_IVA_MASK (1 << OMAP3_SGX_SHIFT)
+#define OMAP3_IVA_MASK (1 << OMAP3_IVA_SHIFT)
#define FEAT_IVA 0
#define FEAT_IVA_NONE 1
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
2010-11-26 11:41 [PATCH] OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT Arno Steffen
@ 2010-11-29 14:29 ` Nishanth Menon
2010-11-29 21:25 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2010-11-29 14:29 UTC (permalink / raw)
To: Arno Steffen; +Cc: linux-omap, tony@atomide.com
Arno Steffen had written, on 11/26/2010 05:41 AM, the following:
minor comment:
$subject could be the commit message probably.. and a smaller subject
like OMAP3: fix typo in OMAP3_IVA_MASK could be used
otherwise, looks good to me.
> Signed-off-by: Arno Steffen <arno.steffen@googlemail.com>
> ---
> arch/arm/mach-omap2/control.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
> index b6c6b7c..5325297 100644
> --- a/arch/arm/mach-omap2/control.h
> +++ b/arch/arm/mach-omap2/control.h
> @@ -309,7 +309,7 @@
> #define FEAT_SGX_NONE 2
>
> #define OMAP3_IVA_SHIFT 12
> -#define OMAP3_IVA_MASK (1 << OMAP3_SGX_SHIFT)
> +#define OMAP3_IVA_MASK (1 << OMAP3_IVA_SHIFT)
> #define FEAT_IVA 0
> #define FEAT_IVA_NONE 1
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
2010-11-29 14:29 ` Nishanth Menon
@ 2010-11-29 21:25 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2010-11-29 21:25 UTC (permalink / raw)
To: Nishanth Menon; +Cc: Arno Steffen, linux-omap
* Nishanth Menon <nm@ti.com> [101129 06:20]:
> Arno Steffen had written, on 11/26/2010 05:41 AM, the following:
>
> minor comment:
> $subject could be the commit message probably.. and a smaller
> subject like OMAP3: fix typo in OMAP3_IVA_MASK could be used
>
> otherwise, looks good to me.
Also, please Cc linux-arm-kernel mailing list too. Otherwise
I have to repost your patch..
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-29 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-26 11:41 [PATCH] OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT Arno Steffen
2010-11-29 14:29 ` Nishanth Menon
2010-11-29 21:25 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox