From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: OMAP4 build error - omapfb Date: Thu, 2 Dec 2010 14:00:24 -0800 Message-ID: <20101202220024.GX17222@atomide.com> References: <20101202212541.GH10461@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:54394 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756209Ab0LBWAp (ORCPT ); Thu, 2 Dec 2010 17:00:45 -0500 Content-Disposition: inline In-Reply-To: <20101202212541.GH10461@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, Tomi Valkeinen * Russell King - ARM Linux [101202 13:15]: > drivers/built-in.o: In function `omapfb_do_probe': > drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl' > > Looks like there's a missing dependency for CONFIG_FB_OMAP. As the > only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c, > and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency > such that it's only available for OMAP1, OMAP2 and OMAP3 ? This is something for Tomi, adding fbdev and Tomi to Cc. Tony > diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig > index 455c605..083c8fe 100644 > --- a/drivers/video/omap/Kconfig > +++ b/drivers/video/omap/Kconfig > @@ -1,7 +1,7 @@ > config FB_OMAP > tristate "OMAP frame buffer support (EXPERIMENTAL)" > - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n") > - > + depends on FB && (OMAP2_DSS = "n") > + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3 > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html