public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Omar Ramirez Luna <omar.ramirez@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	Ohad Ben-Cohen <ohad@wizery.com>, Nishanth Menon <nm@ti.com>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Fernando Guzman Lugo <fernando.lugo@ti.com>,
	Armando Uribe De Leon <x0095078@ti.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Ernesto Ramos Falcon <ernesto@ti.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Rene Sapiens <rene.sapiens@ti.com>
Subject: Re: [PATCH] staging: tidspbridge: remove file handling functions for loader
Date: Wed, 8 Dec 2010 14:26:42 -0800	[thread overview]
Message-ID: <20101208222642.GA31802@kroah.com> (raw)
In-Reply-To: <1291702146-17866-1-git-send-email-omar.ramirez@ti.com>

On Tue, Dec 07, 2010 at 12:09:06AM -0600, Omar Ramirez Luna wrote:
> Instead use request_firmware and friends to get a valid firmware
> image.
> 
> Right now the image is supplied dynamically through udev and the
> following rule:
> 
> KERNEL=="omap-dsp", SUBSYSTEM=="firmware", ACTION=="add",	\
> 	RUN+="/bin/sh -c 'echo 1 > /sys/$DEVPATH/loading;	\
> 		cat $FIRMWARE > /sys/$DEVPATH/data;		\
> 		echo 0 > /sys/$DEVPATH/loading'"

Why do you need a custom firmware rule?  Why doesn't the default
firmware loading rule that comes with udev work properly for you?  What
are you needing different here that works properly for all other
drivers?

confused,

greg k-h

  reply	other threads:[~2010-12-08 22:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07  6:09 [PATCH] staging: tidspbridge: remove file handling functions for loader Omar Ramirez Luna
2010-12-08 22:26 ` Greg KH [this message]
2010-12-08 23:02   ` Ramirez Luna, Omar
2010-12-08 23:08     ` Greg KH
2010-12-08 23:32       ` Ramirez Luna, Omar
2010-12-08 23:49         ` Greg KH
2010-12-10 18:43           ` Ramirez Luna, Omar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101208222642.GA31802@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=ernesto@ti.com \
    --cc=felipe.contreras@gmail.com \
    --cc=fernando.lugo@ti.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ohad@wizery.com \
    --cc=omar.ramirez@ti.com \
    --cc=rene.sapiens@ti.com \
    --cc=x0095078@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox