From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap -> omap_i2c Date: Thu, 9 Dec 2010 23:39:30 +0000 Message-ID: <20101209233930.GV20097@trinity.fluff.org> References: <1291904657-32729-1-git-send-email-b-cousson@ti.com> <1291904657-32729-2-git-send-email-b-cousson@ti.com> <878vzydgxr.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from trinity.fluff.org ([89.16.178.74]:35788 "EHLO trinity.fluff.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756740Ab0LIXjd (ORCPT ); Thu, 9 Dec 2010 18:39:33 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: aaro.koskinen@nokia.com Cc: khilman@deeprootsystems.com, ben-i2c@fluff.org, paul@pwsan.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rnayak@ti.com, b-cousson@ti.com On Thu, Dec 09, 2010 at 10:18:48PM +0000, aaro.koskinen@nokia.com wrote: > Hi, > > Kevin Hilman [khilman@deeprootsystems.com]: > > Ben Dooks writes: > > > Renaming stuff like this is going to have an impact on the userspace > > > as anyone looking through /sys's driver heirarchy is going to miss the > > > old name... > > > > > > It all depends if you really want to go ahead with this... > > > > Yes, we are aware of the userspace impact, but this name change makes > > all devices on OMAP have consistent names and actually improves the > > ability to have userspace tools have consistent naming as well. > > So there are no imporant users, or if there is, they are prepared for this change? > > >> > drivers/i2c/busses/i2c-omap.c | 4 ++-- > > What about the .c / .ko file name? Pretty much everything in the drivers/i2c/busses directory is named i2c-.c, and I would like to keep it that way. -- Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.