Re: [PATCH v3 0/4] Introduce hardware spinlock framework

Ohad Ben-Cohen
2010-12-14T18:40:28Z

On Tue, Dec 14, 2010 at 7:06 PM, Greg KH <greg@kroah.com> wrote:
>> Can you please have a look and say if this looks OK ?
>
> Look at what, I don't see a patch here.

Here's the complete patchset:

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg39833.html

If you prefer, I can resubmit.

>
> I've seen a lot of discussion about this, are all of the review comments
> now addressed?

Yes, all comments were addressed in this v3 iteration, and this thread
has been idle for about 10 days.

>  Like the most important one, why is this generic code if
> it's only for one specific platform?

We started out with an omap-specific driver, but Tony preferred that we
make this a platform-agnostic framework, in order to keep the IPC drivers that
will use it generic, and assuming that more users will show up for
such framework.

To me it sounds reasonable, but both ways (framework / omap-specific
driver) will work for us just fine, and I can switch back to a misc
driver if this is preferred.

The complete discussion of v1 is at:
http://comments.gmane.org/gmane.linux.kernel/1049802

We also discussed this at v2 of the patches with David, see the
complete discussion at:
http://comments.gmane.org/gmane.linux.kernel/1067016

Thanks,
Ohad.

>
> thanks,
>
> greg k-h
>