From mboxrd@z Thu Jan 1 00:00:00 1970 From: "G, Manjunath Kondaiah" Subject: Re: [PATCH v1 4/9] OMAP2430: hwmod data: add system DMA Date: Wed, 15 Dec 2010 21:23:33 +0530 Message-ID: <20101215155333.GA28354@GLPP-machine> References: <1291434246-30716-1-git-send-email-manjugk@ti.com> <1291434246-30716-5-git-send-email-manjugk@ti.com> <20101215105953.GC11931@GLPP-machine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:35248 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753131Ab0LOPwk (ORCPT ); Wed, 15 Dec 2010 10:52:40 -0500 Received: by mail-yw0-f45.google.com with SMTP id 5so1215329ywl.4 for ; Wed, 15 Dec 2010 07:52:40 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: "G, Manjunath Kondaiah" , linux-omap@vger.kernel.org, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Benoit Cousson , Kevin Hilman , Santosh Shilimkar On Wed, Dec 15, 2010 at 08:14:49AM -0700, Paul Walmsley wrote: > On Wed, 15 Dec 2010, G, Manjunath Kondaiah wrote: > > > On Tue, Dec 14, 2010 at 07:27:33PM -0700, Paul Walmsley wrote: > > > On Sat, 4 Dec 2010, G, Manjunath Kondaiah wrote: > > > > > > > Add OMAP2430 DMA hwmod data and also add required > > > > DMA device attributes. > > > > > > ... > > > > > > > +/* dma_system -> L3 */ > > > > +static struct omap_hwmod_ocp_if omap2430_dma_system__l3 = { > > > > + .master = &omap2430_dma_system_hwmod, > > > > + .slave = &omap2430_l3_main_hwmod, > > > > + .clk = "l3_div_ck", > > > > > > This clock does not exist on OMAP2430. Did you test this on OMAP2430? > > > > Yes. I have tested this on SDP2430. For confirmation, I tested again now. > > It boots up without any issues and all DMA test cases are passing. > > Don't you see warnings in the boot messages that this clock cannot be > found? No. I don't see any warnings in boot log. May missing during early prints? -Manjunath