From: Tony Lindgren <tony@atomide.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: David Anders <x0132446@ti.com>,
"Murthy, Raghuveer" <raghuveer.murthy@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line
Date: Fri, 17 Dec 2010 10:02:52 -0800 [thread overview]
Message-ID: <20101217180251.GQ5941@atomide.com> (raw)
In-Reply-To: <AANLkTim_vp6VsdZtN+3ehWuDyw2TE4+x_+f0KZ3Mn6EB@mail.gmail.com>
* Menon, Nishanth <nm@ti.com> [101217 09:50]:
> On Wed, Dec 8, 2010 at 10:49, David Anders <x0132446@ti.com> wrote:
> > On 12/07/2010 06:13 AM, Murthy, Raghuveer wrote:
> >>
> >> The .gpio_cd member of omap2_hsmmc_info is not initialized. This
> >> will default to zero. On Pandaboard this interferes with gpio line
> >> assigned for powering TFP410 DVI chip.
> >>
> >> This fix was missed out in the previous commit bf56f0a6668cd, from
> >> Nishanth Menon
> >>
> >> Signed-off-by: Kishore Kadiyala<kishore.kadiyala@ti.com>
> >> Signed-off-by: Raghuveer Murthy<raghuveer.murthy@ti.com>
> >> Acked-by: Nishanth Menon<nm@ti.com>
> >>
> >
> > Tested-by: David Anders <x0132446@ti.com>
> Tony,
> this is a regression introduced in my commit for .37-rc1. any chance
> of this making to one of 37 rc cycles? I can re-post this patch
> including l-a if that is the path you'd like.
Yes please, and also explain what exactly this breaks.
If it just breaks MMC card detect with some DVI chip driver that's
not merged yet, then this would be in the "it never worked before".
Tony
next prev parent reply other threads:[~2010-12-17 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 12:13 [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line Raghuveer Murthy
2010-12-08 16:49 ` David Anders
2010-12-17 17:50 ` Menon, Nishanth
2010-12-17 18:02 ` Tony Lindgren [this message]
2010-12-17 18:06 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217180251.GQ5941@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=raghuveer.murthy@ti.com \
--cc=x0132446@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox