From: Charles Manning <manningc2@actrix.gen.nz>
To: linux-mtd@lists.infradead.org
Cc: Sukumar Ghorai <s-ghorai@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH v6 2/3] omap3 nand: cleanup virtual address usages
Date: Mon, 20 Dec 2010 10:50:10 +1300 [thread overview]
Message-ID: <201012201050.10726.manningc2@actrix.gen.nz> (raw)
In-Reply-To: <1278660308-8689-3-git-send-email-s-ghorai@ti.com>
On Friday 09 July 2010 19:25:07 Sukumar Ghorai wrote:
> +++ b/arch/arm/plat-omap/include/plat/nand.h
> @@ -21,13 +21,11 @@ struct omap_nand_platform_data {
> int (*dev_ready)(struct omap_nand_platform_data *);
> int dma_channel;
> unsigned long phys_base;
> - void __iomem *gpmc_cs_baseaddr;
> - void __iomem *gpmc_baseaddr;
> int devsize;
> };
>
> -/* size (4 KiB) for IO mapping */
> -#define NAND_IO_SIZE SZ_4K
> +/* minimum size for IO mapping */
> +#define NAND_IO_SIZE 4
Is this really only for a 4-byte region? I would have expected that this
controls access to a multi-register NAND controller and should really be
larger.
-- Charles
next prev parent reply other threads:[~2010-12-19 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 7:25 [PATCH v6 0/3] omap3 nand: cleanup exiting platform related code Sukumar Ghorai
2010-07-09 7:25 ` [PATCH v6 1/3] omap3 gpmc: functionality enhancement Sukumar Ghorai
2010-07-09 7:25 ` [PATCH v6 2/3] omap3 nand: cleanup virtual address usages Sukumar Ghorai
2010-07-09 7:25 ` [PATCH v6 3/3] omap3 nand: fix issue in board file to detect nand Sukumar Ghorai
2010-12-19 21:50 ` Charles Manning [this message]
2010-07-09 8:32 ` [PATCH v6 0/3] omap3 nand: cleanup exiting platform related code Tony Lindgren
2010-07-09 10:59 ` Ghorai, Sukumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012201050.10726.manningc2@actrix.gen.nz \
--to=manningc2@actrix.gen.nz \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-ghorai@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox