public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* Status of CONFIG_OMAP_DM_TIMER
@ 2010-12-23 18:07 Ben Gamari
  2010-12-23 18:07 ` [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER Ben Gamari
  0 siblings, 1 reply; 8+ messages in thread
From: Ben Gamari @ 2010-12-23 18:07 UTC (permalink / raw)
  To: linux-omap, manjugk, santosh.shilimkar, khilman, tony


While compiling a kernel today I found the build was failing with a fair number
of errors while linking vmlinux,

  arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
  /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to `omap_dm_timer_stop'
  /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to `omap_dm_timer_get_fclk'
  /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
  ...

After investigating a bit more deeply, I found that I had neglected to enable
OMAP_DM_TIMER. Looking further, I found that ARCH_OMAP2PLUS builds timer_gp.o,
which itself has symbol dependencies on the dm_timer framework. Given this
face, it seems that the easiest solution would be to do as I have done in this
patch and make ARCH_OMAP2PLUS depend on OMAP_DM_TIMER, since it will not build
without it. That being said, is it necessary to keep OMAP_DM_TIMER
configurable? What is this option actually buying us?

Cheers,

- Ben


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER
@ 2010-12-24  2:48 Ben Gamari
  2010-12-24 17:39 ` Tony Lindgren
  0 siblings, 1 reply; 8+ messages in thread
From: Ben Gamari @ 2010-12-24  2:48 UTC (permalink / raw)
  To: linux-omap, linux-arm-kernel; +Cc: Ben Gamari

It appears that arch/arm/mach-omap2/timer-gp.o is needed by OMAP2PLUS.
Since timer-gp.o has direct dependencies on omap_dm_timer_*, it seems
correct for the architecture to depend upon OMAP_DM_TIMER, otherwise
unsuspecting integrators will be faced with a whole bunch of linker
errors at the end of their kernel build:

arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to `omap_dm_timer_stop'
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to `omap_dm_timer_get_fclk'
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
...
---
 arch/arm/plat-omap/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index 92c5bb7..784c06c 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -18,6 +18,7 @@ config ARCH_OMAP1
 config ARCH_OMAP2PLUS
 	bool "TI OMAP2/3/4"
 	select COMMON_CLKDEV
+	select OMAP_DM_TIMER
 	help
 	  "Systems based on OMAP2, OMAP3 or OMAP4"
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-12-24 17:53 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-23 18:07 Status of CONFIG_OMAP_DM_TIMER Ben Gamari
2010-12-23 18:07 ` [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER Ben Gamari
2010-12-23 20:49   ` Tony Lindgren
2010-12-24  2:53     ` Ben Gamari
2010-12-24  2:43   ` Ben Gamari
  -- strict thread matches above, loose matches on Subject: below --
2010-12-24  2:48 Ben Gamari
2010-12-24 17:39 ` Tony Lindgren
2010-12-24 17:53   ` Ben Gamari

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox